From: Stephen Boyd <sboyd@codeaurora.org>
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org,
Nicolas Pitre <nicolas.pitre@linaro.org>,
Rob Herring <robh@kernel.org>,
Laura Abbott <lauraa@codeaurora.org>,
Liu hua <sdu.liu@huawei.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Tomasz Figa <t.figa@samsung.com>,
Jason Wessel <jason.wessel@windriver.com>,
Will Deacon <will.deacon@arm.com>,
Doug Anderson <dianders@chromium.org>,
Leif Lindholm <leif.lindholm@linaro.org>,
Doug Anderson <dianders@google.com>, Rabin Vincent <rabin@rab.in>,
Nikolay Borisov <Nikolay.Borisov@arm.com>,
Mark Salter <msalter@redhat.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 5/7] arm: kgdb: Handle read-only text / modules
Date: Tue, 12 Aug 2014 12:38:12 -0700 [thread overview]
Message-ID: <53EA6D24.3000609@codeaurora.org> (raw)
In-Reply-To: <1407867869-5194-6-git-send-email-keescook@chromium.org>
On 08/12/14 11:24, Kees Cook wrote:
> @@ -244,6 +248,32 @@ void kgdb_arch_exit(void)
> unregister_die_notifier(&kgdb_notifier);
> }
>
> +int kgdb_arch_set_breakpoint(struct kgdb_bkpt *bpt)
> +{
> + int err;
> +
> + /* patch_text() only supports int-sized breakpoints */
> + if (sizeof(int) != BREAK_INSTR_SIZE)
> + return -EINVAL;
Could this be a BUILD_BUG_ON too?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-08-12 19:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-12 18:24 [PATCH v3 0/7] arm: support CONFIG_RODATA Kees Cook
2014-08-12 18:24 ` [PATCH v3 1/7] arm: use generic fixmap.h Kees Cook
2014-08-12 19:38 ` Kees Cook
2014-08-12 18:24 ` [PATCH v3 2/7] arm: fixmap: implement __set_fixmap() Kees Cook
2014-08-12 18:24 ` [PATCH v3 3/7] arm: use fixmap for text patching when text is RO Kees Cook
2014-08-12 21:39 ` Stephen Boyd
2014-08-12 21:47 ` Kees Cook
2014-08-13 0:27 ` Stephen Boyd
2014-08-13 2:39 ` Kees Cook
2014-08-12 18:24 ` [PATCH v3 4/7] ARM: kexec: Make .text R/W in machine_kexec Kees Cook
2014-08-12 18:24 ` [PATCH v3 5/7] arm: kgdb: Handle read-only text / modules Kees Cook
2014-08-12 19:38 ` Stephen Boyd [this message]
2014-08-12 19:40 ` Kees Cook
2014-08-12 18:24 ` [PATCH v3 6/7] ARM: mm: allow non-text sections to be non-executable Kees Cook
2014-08-12 18:24 ` [PATCH v3 7/7] ARM: mm: allow text and rodata sections to be read-only Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53EA6D24.3000609@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=Nikolay.Borisov@arm.com \
--cc=catalin.marinas@arm.com \
--cc=dianders@chromium.org \
--cc=dianders@google.com \
--cc=jason.wessel@windriver.com \
--cc=keescook@chromium.org \
--cc=lauraa@codeaurora.org \
--cc=leif.lindholm@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=msalter@redhat.com \
--cc=nicolas.pitre@linaro.org \
--cc=rabin@rab.in \
--cc=robh@kernel.org \
--cc=sdu.liu@huawei.com \
--cc=t.figa@samsung.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox