From: "H. Peter Anvin" <hpa@linux.intel.com>
To: Rusty Russell <rusty@rustcorp.com.au>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Amos Kong <akong@redhat.com>,
ricardo.neri-calderon@linux.intel.com, tytso@mit.edu,
Amit Shah <amit.shah@redhat.com>
Subject: Re: [PATCH] virtio: rng: add derating factor for use by hwrng core
Date: Wed, 13 Aug 2014 13:49:06 -0700 [thread overview]
Message-ID: <53EBCF42.8040706@linux.intel.com> (raw)
In-Reply-To: <87zjf88awc.fsf@rustcorp.com.au>
On 08/13/2014 12:09 PM, Rusty Russell wrote:
> The khwrngd thread is started when a hwrng device of sufficient
> quality is registered. The virtio-rng device is backed by the
> hypervisor, and we trust the hypervisor to provide real entropy.
>
> A malicious hypervisor is a scenario that's irrelevant -- such a setup
> is bound to cause all sorts of badness, and a compromised hwrng is not
> the biggest threat.
>
> Given this, we are certain the quality of randomness we receive is
> perfectly trustworthy. Hence, we use 100% for the factor, indicating
> maximum confidence in the source.
>
> Signed-off-by: Amit Shah <amit.shah@redhat.com>
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
> ---
> Pretty small and contained patch; would be great if it is picked up for
> 3.17.
>
> v2: re-word commit msg
>
> [Agreed, re-sending to Linus with SOB before jumping on plane]
Reviewed-by: H. Peter Anvin <hpa@linux.intel.com>
next prev parent reply other threads:[~2014-08-13 20:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 19:09 [PATCH] virtio: rng: add derating factor for use by hwrng core Rusty Russell
2014-08-13 20:49 ` H. Peter Anvin [this message]
2014-08-13 22:44 ` Theodore Ts'o
2014-08-14 18:51 ` Amos Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53EBCF42.8040706@linux.intel.com \
--to=hpa@linux.intel.com \
--cc=akong@redhat.com \
--cc=amit.shah@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ricardo.neri-calderon@linux.intel.com \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox