[PATCH] powercap/rapl: add support for cpu model 0x3f

[PATCH] powercap/rapl: add support for cpu model 0x3f

[Jason Baron]

I've confirmed that monitoring the package power usage as well
as setting power limits appear to be working as expected. However,
I do see in the logs:

[    5.082632] intel_rapl: RAPL domain core detection failed
[    5.088370] intel_rapl: RAPL domain uncore detection failed

So I'm not sure if the h/w simply doesn't support that, or if the
driver could be improved here. In any case, adding the 0x3f makes
the driver useful for me. Tested aginst cpu:

Intel(R) Xeon(R) CPU E5-2650 v3 @ 2.30GHz

Signed-off-by: Jason Baron <jbaron@akamai.com>
---
 drivers/powercap/intel_rapl.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c
index b1cda6f..a362dcc 100644
--- a/drivers/powercap/intel_rapl.c
+++ b/drivers/powercap/intel_rapl.c
@@ -953,6 +953,7 @@ static const struct x86_cpu_id rapl_ids[] = {
 	{ X86_VENDOR_INTEL, 6, 0x3a},/* Ivy Bridge */
 	{ X86_VENDOR_INTEL, 6, 0x3c},/* Haswell */
 	{ X86_VENDOR_INTEL, 6, 0x3d},/* Broadwell */
+	{ X86_VENDOR_INTEL, 6, 0x3f},/* Haswell */
 	{ X86_VENDOR_INTEL, 6, 0x45},/* Haswell ULT */
 	/* TODO: Add more CPU IDs after testing */
 	{}
-- 
1.8.2.rc2

Re: [PATCH] powercap/rapl: add support for cpu model 0x3f

[Jacob Pan]

On Wed, 13 Aug 2014 20:33:26 +0000 (GMT)
Jason Baron <jbaron@akamai.com> wrote:

> I've confirmed that monitoring the package power usage as well
> as setting power limits appear to be working as expected. However,
> I do see in the logs:
> 
> [    5.082632] intel_rapl: RAPL domain core detection failed
> [    5.088370] intel_rapl: RAPL domain uncore detection failed
> 
> So I'm not sure if the h/w simply doesn't support that, or if the
> driver could be improved here. In any case, adding the 0x3f makes
> the driver useful for me. Tested aginst cpu:
> 
> Intel(R) Xeon(R) CPU E5-2650 v3 @ 2.30GHz
> 
I don't have this CPU model to test. Most server processors don't
have uncore domain so detection failed is normal. Looks like you just
have package and dram domain?
Thanks for testing it out, looks good to me. can you send it to
linux-pm list and cc rafael?

> Signed-off-by: Jason Baron <jbaron@akamai.com>
> ---
>  drivers/powercap/intel_rapl.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/powercap/intel_rapl.c
> b/drivers/powercap/intel_rapl.c index b1cda6f..a362dcc 100644
> --- a/drivers/powercap/intel_rapl.c
> +++ b/drivers/powercap/intel_rapl.c
> @@ -953,6 +953,7 @@ static const struct x86_cpu_id rapl_ids[] = {
>  	{ X86_VENDOR_INTEL, 6, 0x3a},/* Ivy Bridge */
>  	{ X86_VENDOR_INTEL, 6, 0x3c},/* Haswell */
>  	{ X86_VENDOR_INTEL, 6, 0x3d},/* Broadwell */
> +	{ X86_VENDOR_INTEL, 6, 0x3f},/* Haswell */
>  	{ X86_VENDOR_INTEL, 6, 0x45},/* Haswell ULT */
>  	/* TODO: Add more CPU IDs after testing */
>  	{}

[Jacob Pan]

Re: [PATCH] powercap/rapl: add support for cpu model 0x3f

[Jason Baron]

On 08/13/2014 06:50 PM, Jacob Pan wrote:
> On Wed, 13 Aug 2014 20:33:26 +0000 (GMT)
> Jason Baron <jbaron@akamai.com> wrote:
> 
>> I've confirmed that monitoring the package power usage as well
>> as setting power limits appear to be working as expected. However,
>> I do see in the logs:
>>
>> [    5.082632] intel_rapl: RAPL domain core detection failed
>> [    5.088370] intel_rapl: RAPL domain uncore detection failed
>>
>> So I'm not sure if the h/w simply doesn't support that, or if the
>> driver could be improved here. In any case, adding the 0x3f makes
>> the driver useful for me. Tested aginst cpu:
>>
>> Intel(R) Xeon(R) CPU E5-2650 v3 @ 2.30GHz
>>
> I don't have this CPU model to test. Most server processors don't
> have uncore domain so detection failed is normal. Looks like you just
> have package and dram domain?

Yes.

> Thanks for testing it out, looks good to me. can you send it to
> linux-pm list and cc rafael?
> 

Ok.

Thanks,

-Jason