From: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
To: Borislav Petkov <bp@suse.de>
Cc: Clemens Ladisch <clemens@ladisch.de>,
Guenter Roeck <linux@roeck-us.net>, <jdelvare@suse.de>,
<rdunlap@infradead.org>, <tglx@linutronix.de>, <mingo@redhat.com>,
<hpa@zytor.com>, <dan.carpenter@oracle.com>,
<lm-sensors@lm-sensors.org>, <linux-doc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] hwmon, k10temp: Add support for F15h M60h
Date: Thu, 14 Aug 2014 17:20:15 -0500 [thread overview]
Message-ID: <53ED361F.4010009@amd.com> (raw)
In-Reply-To: <20140814220530.GD18887@pd.tnic>
On 8/14/2014 5:05 PM, Borislav Petkov wrote:
> On Thu, Aug 14, 2014 at 04:57:17PM -0500, Aravind Gopalakrishnan wrote:
>> Actually I don't need it outside of k10temp as of now (or near future)
>> I added it in amd_nb as that was Clemens, Guenter's suggestion on the
>> previous version;
>> Besides, it made sense as it's an indirect access of NB_SMU register and
>> amd_nb seems a good place to put the function in case someone needs it in
>> the future.
> Then someone can move it then. But until that happens it is pretty
> pointless of having the Kconfig dependency just for one small function
> with a single user.
>
>> I can move it locally to k10temp and remove the dependency if that's
>> more preferable.
> Yeah, it looks like a fabricated and not true dependency, which doesn't
> make any sense currently.
>
> Thanks.
>
Ok, Will fix this and send V3.
-Aravind.
prev parent reply other threads:[~2014-08-14 22:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 16:54 [PATCH V2] hwmon, k10temp: Add support for F15h M60h Aravind Gopalakrishnan
2014-08-14 17:32 ` Clemens Ladisch
2014-08-14 20:17 ` Guenter Roeck
2014-08-14 20:22 ` Clemens Ladisch
2014-08-14 21:08 ` Borislav Petkov
2014-08-14 21:57 ` Aravind Gopalakrishnan
2014-08-14 22:05 ` Borislav Petkov
2014-08-14 22:20 ` Aravind Gopalakrishnan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53ED361F.4010009@amd.com \
--to=aravind.gopalakrishnan@amd.com \
--cc=bp@suse.de \
--cc=clemens@ladisch.de \
--cc=dan.carpenter@oracle.com \
--cc=hpa@zytor.com \
--cc=jdelvare@suse.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=mingo@redhat.com \
--cc=rdunlap@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox