From: Matias Bjorling <m@bjorling.me>
To: Keith Busch <keith.busch@intel.com>, Jens Axboe <axboe@fb.com>
Cc: Matthew Wilcox <willy@linux.intel.com>,
"Sam Bradshaw (sbradshaw)" <sbradshaw@micron.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-nvme <linux-nvme@lists.infradead.org>,
Christoph Hellwig <hch@infradead.org>,
Rob Nelson <rlnelson@google.com>,
Ming Lei <tom.leiming@gmail.com>
Subject: Re: [PATCH v11] NVMe: Convert to blk-mq
Date: Fri, 15 Aug 2014 12:09:47 +0200 [thread overview]
Message-ID: <53EDDC6B.40007@bjorling.me> (raw)
In-Reply-To: <alpine.LRH.2.03.1408141651300.14603@AMR>
On 08/15/2014 01:09 AM, Keith Busch wrote:
>
> The allocation and freeing of blk-mq parts seems a bit asymmetrical
> to me. The 'tags' belong to the tagset, but any request_queue using
> that tagset may free the tags. I looked to separate the tag allocation
> concerns, but that's more time than I have, so this is my quick-fix
> driver patch, forcing tag access through the hw_ctx.
>
I moved nvmeq->hctx->tags into nvmeq->tags in the last version. I missed
the free's in blk_mq_map_swqueue. Good catch.
The previous method might have another problem. If there's two
namespaces, sharing tag set. The hctx_init fn could be called with
different hctx for an nvmeq, leading to false tag sharing between nvme
queues.
prev parent reply other threads:[~2014-08-15 10:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-26 9:07 [PATCH v11] Convert NVMe driver to blk-mq Matias Bjørling
2014-07-26 9:07 ` [PATCH v11] NVMe: Convert " Matias Bjørling
2014-08-10 17:27 ` Matias Bjørling
2014-08-13 22:27 ` Keith Busch
2014-08-14 8:25 ` Matias Bjørling
2014-08-14 15:09 ` Jens Axboe
2014-08-14 15:33 ` Keith Busch
2014-08-14 15:39 ` Matias Bjorling
2014-08-14 18:20 ` Keith Busch
2014-08-14 23:09 ` Keith Busch
2014-08-15 10:09 ` Matias Bjorling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53EDDC6B.40007@bjorling.me \
--to=m@bjorling.me \
--cc=axboe@fb.com \
--cc=hch@infradead.org \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=rlnelson@google.com \
--cc=sbradshaw@micron.com \
--cc=tom.leiming@gmail.com \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox