From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: Mark Brown <broonie@kernel.org>
Cc: Tim Kryger <tim.kryger@gmail.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Chris Ball <chris@printf.net>,
Seungwon Jeon <tgih.jun@samsung.com>,
Haijun Zhang <Haijun.Zhang@freescale.com>,
Doug Anderson <dianders@chromium.org>,
Olof Johansson <olof@lixom.net>,
Yuvaraj Kumar C D <yuvaraj.cd@gmail.com>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
linux-mmc <linux-mmc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] mmc: core: Use regulator_get_voltage() if OCR mask is empty.
Date: Fri, 15 Aug 2014 13:13:42 +0200 [thread overview]
Message-ID: <53EDEB66.1040304@collabora.co.uk> (raw)
In-Reply-To: <20140815095528.GH17528@sirena.org.uk>
Hello Mark,
On 08/15/2014 11:55 AM, Mark Brown wrote:
> On Fri, Aug 15, 2014 at 09:48:43AM +0200, Javier Martinez Canillas wrote:
>
>> But now I wonder why regulator_list_voltage() even list the voltage for
>> fixed regulators (desc->fixed_uV) since they don't have the ability to
>
> That's because it's very cheap to do and there is a comprehensible thing
> we can return - if we have to read the voltage that means potentially
> asking the hardware in an I2C transaction which is not cheap.
>
Thanks a lot for the explanation, that does make a lot of sense.
>
> There's plenty of potentially variable regulators used in these
> situations, I expect it's more likely that people were just ignoring the
> warning since it has no practical effect.
>
Indeed.
Best regards,
Javier
next prev parent reply other threads:[~2014-08-15 11:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 12:39 [PATCH 1/1] mmc: core: Use regulator_get_voltage() if OCR mask is empty Javier Martinez Canillas
2014-08-14 14:13 ` Tim Kryger
2014-08-14 15:19 ` Mark Brown
2014-08-15 5:36 ` Tim Kryger
2014-08-15 7:48 ` Javier Martinez Canillas
2014-08-15 9:55 ` Mark Brown
2014-08-15 11:13 ` Javier Martinez Canillas [this message]
2014-08-15 14:51 ` Ulf Hansson
2014-08-16 12:59 ` Mark Brown
2014-08-19 11:29 ` Javier Martinez Canillas
2014-08-19 12:43 ` Ulf Hansson
2014-08-19 12:54 ` Javier Martinez Canillas
2014-08-15 14:19 ` Tim Kryger
2014-08-15 22:29 ` Mark Brown
2014-08-17 17:11 ` Tim Kryger
2014-08-18 13:18 ` Mark Brown
2014-08-15 8:59 ` Mark Brown
2014-08-14 15:29 ` Javier Martinez Canillas
2014-08-19 12:51 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53EDEB66.1040304@collabora.co.uk \
--to=javier.martinez@collabora.co.uk \
--cc=Haijun.Zhang@freescale.com \
--cc=broonie@kernel.org \
--cc=chris@printf.net \
--cc=dianders@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=tgih.jun@samsung.com \
--cc=tim.kryger@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=yuvaraj.cd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox