Re: [lm-sensors] [PATCH V3] hwmon, k10temp: Add support for F15h M60h

Guenter Roeck
2014-08-15T15:39:29Z

On 08/15/2014 08:18 AM, Phil Pokorny wrote:
>
> On 08/14/2014 04:15 PM, Aravind Gopalakrishnan wrote:
>
> This patch adds temperature monitoring support for F15h M60h processor.
> - Add new pci device id for the relevant processor
> - The functionality of REG_REPORTED_TEMPERATURE is moved to
> D0F0xBC_xD820_0CA4 [Reported Temperature Control]
> - So, use this to get CUR_TEMP value
> - Since we need an indirect register access, protect this with
> a mutex lock
>
>
> What about making this a new driver forked from k10temp.
>
> AMD has changed how they report temperatures and the very different method of getting these temps suggests that it is no longer reasonable to add support to this driver for these new chips. Particular attention to the mutex required to protect the indirect register suggests that this would benefit from focus in its own driver now that there are multiple members of the "k15temp" family.
>
> Anyone else have thoughts?
>

Everything in that new driver except for reading the actual temperature
would be exactly the same. That doesn't make sense to me.

Guenter