Re: [PATCH V3] hwmon, k10temp: Add support for F15h M60h

Aravind Gopalakrishnan
2014-08-15T14:49:48Z

On 8/15/2014 5:45 AM, Guenter Roeck wrote:
> On 08/14/2014 04:15 PM, Aravind Gopalakrishnan wrote:
>> This patch adds temperature monitoring support for F15h M60h processor.
>> - Add new pci device id for the relevant processor
>> - The functionality of REG_REPORTED_TEMPERATURE is moved to
>> D0F0xBC_xD820_0CA4 [Reported Temperature Control]
>> - So, use this to get CUR_TEMP value
>> - Since we need an indirect register access, protect this with
>> a mutex lock
>> - Add Kconfig, Doc entries to indicate support for this processor.
>>
>> Signed-off-by: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
>> ---
>> Changes in V3:
>> - Move helper function that protects indirect register access locally
>> until a time when others outside k10temp may need it
>>
>
> Applied, with a small change: I made the mutex and the new function
> static.
> That can be changed if/when needed, and declaring it static now
> ensures that
> we'll notice it. Likely the "next" user won't use the function anyway,
> but
> that is a problem to sort out after it happens.
>

Ok, Thanks!
-Aravind.