From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@canonical.com>, linux-kernel@vger.kernel.org
Cc: Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH] blk-mq: fix WARNING "percpu_ref_kill() called more than once!"
Date: Fri, 15 Aug 2014 12:37:03 -0600 [thread overview]
Message-ID: <53EE534F.2040208@kernel.dk> (raw)
In-Reply-To: <1408115792-3311-1-git-send-email-ming.lei@canonical.com>
On 2014-08-15 09:16, Ming Lei wrote:
> Before doing queue release, the queue has been freezed already
> by blk_cleanup_queue(), so needn't to freeze queue for deleting
> tag set.
>
> This patch fixes the WARNING of "percpu_ref_kill() called more than once!"
> which is triggered during unloading block driver.
Thanks, you are right, we need not call it there. I'll apply this for 3.17.
--
Jens Axboe
next prev parent reply other threads:[~2014-08-15 18:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-15 15:16 [PATCH] blk-mq: fix WARNING "percpu_ref_kill() called more than once!" Ming Lei
2014-08-15 18:37 ` Jens Axboe [this message]
2014-08-16 12:02 ` [PATCH] blk-mq: blk_mq_freeze_queue() should allow nesting Tejun Heo
2014-08-16 13:30 ` Ming Lei
2014-08-17 17:47 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53EE534F.2040208@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox