Re: 回复： Re: [PATCH] unicore32: Fix build error

[Guenter Roeck <linux@roeck-us.net>]

On 08/15/2014 05:45 PM, Xuetao Guan  wrote:
>
> ----- Guenter Roeck <linux@roeck-us.net> 写道：
>> On 08/10/2014 08:29 AM, Guenter Roeck wrote:
>>> unicore32 builds fail with
>>>
>>> arch/unicore32/kernel/signal.c: In function ‘setup_frame’:
>>> arch/unicore32/kernel/signal.c:257: error:
>>> 			‘usig’ undeclared (first use in this function)
>>> arch/unicore32/kernel/signal.c:279: error:
>>> 			‘usig’ undeclared (first use in this function)
>>> arch/unicore32/kernel/signal.c: In function ‘handle_signal’:
>>> arch/unicore32/kernel/signal.c:306: warning: unused variable ‘tsk’
>>> arch/unicore32/kernel/signal.c: In function ‘do_signal’:
>>> arch/unicore32/kernel/signal.c:376: error:
>>> 			implicit declaration of function ‘get_signsl’
>>> make[1]: *** [arch/unicore32/kernel/signal.o] Error 1
>>> make: *** [arch/unicore32/kernel/signal.o] Error 2
>>>
>>> Bisect points to commit 649671c90eaf ("unicore32: Use get_signal()
>>> signal_setup_done()").
>>>
>>> This code never even compiled. Reverting the patch does not work,
>>> since previously used functions no longer exist, so try to fix it up.
>>> Compile tested only.
>>>
>>> Cc: Richard Weinberger <richard@nod.at>
>>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>>
>> ping ...
>>
>> Failure is still present in upstream kernel (v3.16-11383-gc9d2642).
>>
>> Guenter
>>
>
> Thanks. I'll fix it.
>

More a question of applying (and if possible testing) the patch I provided.

Thanks,
Guenter