Re: [PATCH] unicore32: Fix build error

Guenter Roeck
2014-08-10T16:30:22Z

On 08/10/2014 08:39 AM, Richard Weinberger wrote:
> Guenther,
>
> Am 10.08.2014 17:29, schrieb Guenter Roeck:
>> unicore32 builds fail with
>>
>> arch/unicore32/kernel/signal.c: In function ‘setup_frame’:
>> arch/unicore32/kernel/signal.c:257: error:
>> ‘usig’ undeclared (first use in this function)
>> arch/unicore32/kernel/signal.c:279: error:
>> ‘usig’ undeclared (first use in this function)
>> arch/unicore32/kernel/signal.c: In function ‘handle_signal’:
>> arch/unicore32/kernel/signal.c:306: warning: unused variable ‘tsk’
>> arch/unicore32/kernel/signal.c: In function ‘do_signal’:
>> arch/unicore32/kernel/signal.c:376: error:
>> implicit declaration of function ‘get_signsl’
>> make[1]: *** [arch/unicore32/kernel/signal.o] Error 1
>> make: *** [arch/unicore32/kernel/signal.o] Error 2
>>
>> Bisect points to commit 649671c90eaf ("unicore32: Use get_signal()
>> signal_setup_done()").
>>
>> This code never even compiled. Reverting the patch does not work,
>> since previously used functions no longer exist, so try to fix it up.
>> Compile tested only.
>
> Where did you get the unicore32 cross compiler from?
>
mprc.pku.edu.cn/~guanxuetao/linux/uc4-1.0.5-hard.tgz

Guenter