From: Rik van Riel <riel@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
umgwanakikbuti@gmail.com, fweisbec@gmail.com,
akpm@linux-foundation.org, srao@redhat.com, lwoodman@redhat.com,
atheurer@redhat.com
Subject: Re: [PATCH 2/3] time,signal: protect resource use statistics with seqlock
Date: Sat, 16 Aug 2014 11:07:55 -0400 [thread overview]
Message-ID: <53EF73CB.6020404@redhat.com> (raw)
In-Reply-To: <20140816141159.GA8709@redhat.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 08/16/2014 10:11 AM, Oleg Nesterov wrote:
>> + /* + * If a writer is currently active, seq will be odd,
>> and + * read_seqbegin_or_lock will take the lock. + */ +
>> nextseq = raw_read_seqcount(&sig->stats_lock.seqcount); + } while
>> (need_seqretry(&sig->stats_lock, seq)); +
>> done_seqretry(&sig->stats_lock, seq); rcu_read_unlock(); }
>
> Rik, I do not understand why did you silently ignore my comments
> about this change twice ;)
I can explain why it appears that way.
I made the fix you suggested in one tree, and did my
"guilt patchbomb" from another tree. Doh...
- --
All rights reversed
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQEcBAEBAgAGBQJT73PLAAoJEM553pKExN6DPNcH/jWQ1qKSyW9rDOETjGAkau2r
KcVoeaqliqYhNi6IDDpqZb0LvOFp9jD+ykiwxGD4KjoNX3iR0pLE7ymm3mh/dH7q
0t3zI+640ydbd5WEcVkpPMT6C0pdPNuEM01iuM0YExWErLPbhFuGcgV7fUn1idTx
L//L9OQNImTxRPPYr+4OEGZh99CqnBG3PjoCtXoa4dvsqsrz2SQ/yUtfAlF4veVY
C6nLdt5zfehaRypzzufsYbyMjLm2uXufEuqibeJI0G2w/qB4Q0+80d+JytETB9Q3
R1VWDjQrLjrIPbMNVkXKK+Px/q7d5q+DPE+uB0lmpmcjIqBJjVhviw/wx9AhJc4=
=Gm8e
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2014-08-16 15:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-15 20:05 [PATCH 0/3] lockless sys_times and posix_cpu_clock_get riel
2014-08-15 20:05 ` [PATCH 1/3] exit: always reap resource stats in __exit_signal riel
2014-09-08 6:39 ` [tip:sched/core] exit: Always reap resource stats in __exit_signal() tip-bot for Rik van Riel
2014-08-15 20:05 ` [PATCH 2/3] time,signal: protect resource use statistics with seqlock riel
2014-08-16 14:11 ` Oleg Nesterov
2014-08-16 15:07 ` Rik van Riel [this message]
2014-08-16 17:40 ` [PATCH v2 " Rik van Riel
2014-08-16 17:50 ` Oleg Nesterov
2014-08-18 4:44 ` Mike Galbraith
2014-08-18 14:03 ` Rik van Riel
2014-08-19 14:26 ` Mike Galbraith
2014-09-08 6:39 ` [tip:sched/core] time, signal: Protect " tip-bot for Rik van Riel
2014-08-15 20:05 ` [PATCH 3/3] sched,time: atomically increment stime & utime riel
2014-08-16 14:55 ` Oleg Nesterov
2014-08-16 14:56 ` Oleg Nesterov
2014-09-08 6:40 ` [tip:sched/core] sched, time: Atomically " tip-bot for Rik van Riel
2014-08-19 21:21 ` [PATCH 0/3] lockless sys_times and posix_cpu_clock_get Andrew Theurer
2014-09-03 18:38 ` Rik van Riel
2014-09-04 7:48 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53EF73CB.6020404@redhat.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=atheurer@redhat.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lwoodman@redhat.com \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=srao@redhat.com \
--cc=umgwanakikbuti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).