From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752710AbaHRKUj (ORCPT ); Mon, 18 Aug 2014 06:20:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1526 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750906AbaHRKUh (ORCPT ); Mon, 18 Aug 2014 06:20:37 -0400 Message-ID: <53F1D36C.8070606@redhat.com> Date: Mon, 18 Aug 2014 12:20:28 +0200 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Wanpeng Li CC: Gleb Natapov , hpa@zytor.com, x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Avi Kivity Subject: Re: [PATCH 2/5] KVM: x86: drop fpu_activate hook References: <1408355431-115633-1-git-send-email-wanpeng.li@linux.intel.com> <1408355431-115633-2-git-send-email-wanpeng.li@linux.intel.com> In-Reply-To: <1408355431-115633-2-git-send-email-wanpeng.li@linux.intel.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 18/08/2014 11:50, Wanpeng Li ha scritto: > fpu_activate hook is introduced by commit 6b52d186 (KVM: Activate fpu on > clts), however, there is no user currently, this patch drop it. > > Reviewed-by: Yang Zhang > Signed-off-by: Wanpeng Li > --- > arch/x86/include/asm/kvm_host.h | 1 - > arch/x86/kvm/svm.c | 1 - > arch/x86/kvm/vmx.c | 1 - > 3 files changed, 3 deletions(-) > > diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h > index 5724601..b68f3e5 100644 > --- a/arch/x86/include/asm/kvm_host.h > +++ b/arch/x86/include/asm/kvm_host.h > @@ -710,7 +710,6 @@ struct kvm_x86_ops { > void (*cache_reg)(struct kvm_vcpu *vcpu, enum kvm_reg reg); > unsigned long (*get_rflags)(struct kvm_vcpu *vcpu); > void (*set_rflags)(struct kvm_vcpu *vcpu, unsigned long rflags); > - void (*fpu_activate)(struct kvm_vcpu *vcpu); > void (*fpu_deactivate)(struct kvm_vcpu *vcpu); > > void (*tlb_flush)(struct kvm_vcpu *vcpu); > diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c > index ddf7427..1f49c86 100644 > --- a/arch/x86/kvm/svm.c > +++ b/arch/x86/kvm/svm.c > @@ -4349,7 +4349,6 @@ static struct kvm_x86_ops svm_x86_ops = { > .cache_reg = svm_cache_reg, > .get_rflags = svm_get_rflags, > .set_rflags = svm_set_rflags, > - .fpu_activate = svm_fpu_activate, > .fpu_deactivate = svm_fpu_deactivate, > > .tlb_flush = svm_flush_tlb, > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c > index 71cbee5..2963303 100644 > --- a/arch/x86/kvm/vmx.c > +++ b/arch/x86/kvm/vmx.c > @@ -8896,7 +8896,6 @@ static struct kvm_x86_ops vmx_x86_ops = { > .cache_reg = vmx_cache_reg, > .get_rflags = vmx_get_rflags, > .set_rflags = vmx_set_rflags, > - .fpu_activate = vmx_fpu_activate, > .fpu_deactivate = vmx_fpu_deactivate, > > .tlb_flush = vmx_flush_tlb, > Avi/Gleb, do you remember any particular reason for this? Paolo