From: Paolo Bonzini <pbonzini@redhat.com>
To: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>,
Wanpeng Li <wanpeng.li@linux.intel.com>
Cc: Gleb Natapov <gleb@kernel.org>,
hpa@zytor.com, x86@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] KVM: vmx: fix ept reserved bits for 1-GByte page
Date: Mon, 18 Aug 2014 13:18:37 +0200 [thread overview]
Message-ID: <53F1E10D.7060007@redhat.com> (raw)
In-Reply-To: <53F1DADA.1050603@linux.vnet.ibm.com>
Il 18/08/2014 12:52, Xiao Guangrong ha scritto:
>> > EPT misconfig handler in kvm will check which reason lead to EPT
>> > misconfiguration after vmexit. One of the reasons is that an EPT
>> > paging-structure entry is configured with settings reserved for
>> > future functionality. However, the handler can't identify if
>> > paging-structure entry of reserved bits for 1-GByte page are
>> > configured, since PDPTE which point to 1-GByte page will reserve
>> > bits 29:12 instead of bits 7:3 which are reserved for PDPTE that
>> > references an EPT Page Directory. This patch fix it by reserve
>> > bits 29:12 for 1-GByte page.
> That mask is only set in the lowest pte for 4K page, i think it
> is not a problem, no?
It will cause KVM to WARN. The EPT memory type will also be ignored for
gigabyte pages.
Paolo
prev parent reply other threads:[~2014-08-18 11:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-18 9:50 [PATCH 1/5] KVM: vmx: fix ept reserved bits for 1-GByte page Wanpeng Li
2014-08-18 9:50 ` [PATCH 2/5] KVM: x86: drop fpu_activate hook Wanpeng Li
2014-08-18 10:20 ` Paolo Bonzini
2014-08-18 10:26 ` Avi Kivity
2014-08-18 10:51 ` Paolo Bonzini
2014-08-18 11:15 ` Avi Kivity
2014-08-18 10:52 ` Paolo Bonzini
2014-08-18 9:50 ` [PATCH 3/5] KVM: vmx: don't vmx_segment_cache_clear twice in enter_pmode Wanpeng Li
2014-08-18 10:24 ` Paolo Bonzini
2014-08-18 9:50 ` [PATCH 4/5] KVM: x86: fix check legal type of Variable Range MTRRs Wanpeng Li
2014-08-18 10:28 ` Paolo Bonzini
2014-08-18 9:50 ` [PATCH 5/5] KVM: x86: #GP when attempts to write reserved bits " Wanpeng Li
2014-08-18 12:27 ` Wanpeng Li
2014-08-18 12:49 ` Paolo Bonzini
2014-08-18 10:18 ` [PATCH 1/5] KVM: vmx: fix ept reserved bits for 1-GByte page Paolo Bonzini
2014-08-19 2:17 ` Wanpeng Li
2014-08-19 6:11 ` Paolo Bonzini
2014-08-18 10:52 ` Xiao Guangrong
2014-08-18 11:18 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F1E10D.7060007@redhat.com \
--to=pbonzini@redhat.com \
--cc=gleb@kernel.org \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wanpeng.li@linux.intel.com \
--cc=x86@kernel.org \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox