From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751958AbaHRQww (ORCPT ); Mon, 18 Aug 2014 12:52:52 -0400 Received: from smtp-out-050.synserver.de ([212.40.185.50]:1060 "EHLO smtp-out-045.synserver.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751569AbaHRQwv (ORCPT ); Mon, 18 Aug 2014 12:52:51 -0400 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 20540 Message-ID: <53F22F5E.2090601@metafoo.de> Date: Mon, 18 Aug 2014 18:52:46 +0200 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.7.0 MIME-Version: 1.0 To: Shengjiu Wang , lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.de, nicoleotsuka@gmail.com, Li.Xiubo@freescale.com, shc_work@mail.ru, fabio.estevam@freescale.com, xobs@kosagi.com, arnd@arndb.de, sfr@canb.auug.org.au, timur@tabi.org CC: alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Arnd Bergmann Subject: Re: [alsa-devel] [PATCH V1 1/3] ASoC: fsl: Kconfig: remove dependence of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/18/2014 10:38 AM, Shengjiu Wang wrote: > Build kernel with SND_SOC_IMC_PCM_DMA=m && SND_IMX_SOC=n leads the following > error: > > sound/built-in.o: In function `fsl_sai_probe': >>> fsl_sai.c:(.text+0x5f662): undefined reference to `imx_pcm_dma_init' > sound/built-in.o: In function `fsl_esai_probe': >>> fsl_esai.c:(.text+0x6044b): undefined reference to `imx_pcm_dma_init' > > Most cpu driver in soc/fsl has use the function 'imx_pcm_dma_init' which is > defined in imx-pcm-dma.c, so need to select SND_SOC_IMX_PCM_DMA, but it depends > on SND_IMX_SOC, if SND_IMX_SOC=n, then SND_SOC_IMX_PCM_DMA will not be > selected. > So remove the dependence of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA. > > Reported-by: kbuild test robot > Signed-off-by: Shengjiu Wang Those if conditions where just added[1] by Arnd to avoid other build failures. So just removing them again makes little sense. As far as I can see imx_pcm_dma_init() should be stubbed out when SND_SOC_IMX_PCM_DMA is not selected. So what's going on here? [1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=ff40260f79dc0436604452bccd449bffd25ebafb