From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753314AbaHSPoQ (ORCPT ); Tue, 19 Aug 2014 11:44:16 -0400 Received: from mail-pd0-f177.google.com ([209.85.192.177]:53565 "EHLO mail-pd0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752737AbaHSPoO (ORCPT ); Tue, 19 Aug 2014 11:44:14 -0400 Message-ID: <53F370CD.80201@gmail.com> Date: Tue, 19 Aug 2014 23:44:13 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: gleb@kernel.org, pbonzini@redhat.com CC: kvm@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] virt/kvm/assigned-dev.c: Set 'dev->irq_source_id' to '-1' after free it References: <53E4EED7.6050302@gmail.com> In-Reply-To: <53E4EED7.6050302@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello maintainers: Please help check this patch, when you have time. Thanks. On 08/08/2014 11:37 PM, Chen Gang wrote: > As a generic function, deassign_guest_irq() assumes it can be called > even if assign_guest_irq() is not be called successfully (which can be > triggered by ioctl from user mode, indirectly). > > So for assign_guest_irq() failure process, need set 'dev->irq_source_id' > to -1 after free 'dev->irq_source_id', or deassign_guest_irq() may free > it again. > > Signed-off-by: Chen Gang > --- > virt/kvm/assigned-dev.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/virt/kvm/assigned-dev.c b/virt/kvm/assigned-dev.c > index bf06577..5819a27 100644 > --- a/virt/kvm/assigned-dev.c > +++ b/virt/kvm/assigned-dev.c > @@ -526,8 +526,10 @@ static int assign_guest_irq(struct kvm *kvm, > dev->irq_requested_type |= guest_irq_type; > if (dev->ack_notifier.gsi != -1) > kvm_register_irq_ack_notifier(kvm, &dev->ack_notifier); > - } else > + } else { > kvm_free_irq_source_id(kvm, dev->irq_source_id); > + dev->irq_source_id = -1; > + } > > return r; > } > -- Chen Gang Open share and attitude like air water and life which God blessed