Re: [PATCHv2 1/3] fs/buffer.c: allocate buffer cache with user specific flag

Gioh Kim
2014-08-20T02:38:16Z

>>>> @@ -1381,12 +1383,7 @@ EXPORT_SYMBOL(__find_get_block);
>>>> struct buffer_head *
>>>> __getblk(struct block_device *bdev, sector_t block, unsigned size)
>>>> {
>>>> - struct buffer_head *bh = __find_get_block(bdev, block, size);
>>>> -
>>>> - might_sleep();
>>>> - if (bh == NULL)
>>>> - bh = __getblk_slow(bdev, block, size);
>>>> - return bh;
>>>> + return __getblk_gfp(bdev, block, size, __GFP_MOVABLE);
>>>> }
>>>> EXPORT_SYMBOL(__getblk);
>>> Why did you remove the __find_get_block() call? That looks like a bug.
> I'm not sure if you didn't miss this comment....

I'm sorry I missed it.
I think calling __find_get_block() in __getblk_gfp() can replace it.
I'm not sure about it.

If anybody disagree with it, I'll change it as the original code.