From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752702AbaHTMuk (ORCPT ); Wed, 20 Aug 2014 08:50:40 -0400 Received: from cantor2.suse.de ([195.135.220.15]:45735 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752136AbaHTMuh (ORCPT ); Wed, 20 Aug 2014 08:50:37 -0400 Message-ID: <53F49996.30007@suse.de> Date: Wed, 20 Aug 2014 14:50:30 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Organization: SUSE LINUX Products GmbH User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Doug Anderson , Kukjin Kim CC: linux-samsung-soc , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , Stephan van Schaik , Vincent Palatin , Javier Martinez Canillas , Tomasz Figa , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Ben Dooks , LKML , Julius Werner Subject: Re: [PATCH v6 10/10] ARM: dts: Add exynos5250-spring device tree References: <1406940750-15880-1-git-send-email-afaerber@suse.de> <1406940750-15880-11-git-send-email-afaerber@suse.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kukjin, Am 04.08.2014 17:22, schrieb Doug Anderson: > On Fri, Aug 1, 2014 at 5:52 PM, Andreas Färber wrote: >> diff --git a/arch/arm/boot/dts/exynos5250-spring.dts b/arch/arm/boot/dts/exynos5250-spring.dts >> new file mode 100644 >> index 000000000000..f5566f84d885 >> --- /dev/null >> +++ b/arch/arm/boot/dts/exynos5250-spring.dts [...] >> + usb-hub { >> + compatible = "smsc,usb3503a"; >> + reset-gpios = <&gpe1 0 GPIO_ACTIVE_LOW>; >> + }; > > Last I remember hearing about this, Julius said that the generic > usb-hub driver didn't work right for asserting the reset line. > Something about needing the reset at a very specific time in the USB > enumeration, I think. Maybe it's somehow been fixed since then and > that's why it's working? > > Also: you technically should have a pinctrl-0 and pinctrl-names > referencing "hsic_reset" below to make sure the pin gets initted > properly. [...] > Technically the missing pinctrl for hsic-reset is something that out > to be fixed and we should figure out whether the reset line is > actually working properly anyway. ...but I think this has been > through enough spins and any additional fixup can happen later, so you > can add my: > > Reviewed-by: Doug Anderson I wonder how to proceed now... Are you planning to continue inserting my remaining snow/smdk/arndale refactoring patches [1,2,3,4] before the mmc slot node refactoring on v3.18-next/dt-samsung branch? I.e., should I send out a v7 rebasing either the remainder or just Spring on top of your for-next, or should I just post new follow-up patches to this series and wait? I've prepared and successfully tested a patch adding the pinctrl Doug requested above. Additionally, I have another follow-up ready, adding a gmt,g781 temperature sensor (with v3.17-rc1 that actually works). Also I understood that Javier is waiting for my remaining Snow bits to be applied before sending out further Snow DT cleanups/fixes of his. Thanks, Andreas [1] https://patchwork.kernel.org/patch/4664881/ [2] https://patchwork.kernel.org/patch/4664801/ [3] https://patchwork.kernel.org/patch/4664731/ [4] https://patchwork.kernel.org/patch/4664751/ -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg