From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: balbi@ti.com, Richard Leitner <richard.leitner@skidata.com>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC] usb: gadget: serial: remove PREFIX macro
Date: Wed, 20 Aug 2014 20:39:10 +0400 [thread overview]
Message-ID: <53F4CF2E.2070605@cogentembedded.com> (raw)
In-Reply-To: <20140820155417.GD24500@saruman.home>
Hello.
On 08/20/2014 07:54 PM, Felipe Balbi wrote:
>> Remove the ttyGS PREFIX macro from u_serial.c and replace all occurences with
>> the hardcoded ttyGS string.
>> This macro was mostly used in a few debug/warning messages and a lot of
>> hardcoded ttyGS existed beneath. It may have been used for renaming the
>> tty, but if done so most debug messages would have ignored this because
>> of the hardcoded strings.
>> Due to the fact the usage of this PREFIX instead of the hardcoded strings
>> in all debug calls would have resulted in a hard to read/grep code it
>> is removed completely.
>> Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
> patch looks fine, can you resend with RFC in the subject ?
s/with/without/?
WBR, Sergei
next prev parent reply other threads:[~2014-08-20 16:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 9:39 [RFC] usb: gadget: serial: remove PREFIX macro Richard Leitner
2014-08-11 13:04 ` Richard Leitner
2014-08-11 13:50 ` Felipe Balbi
2014-08-11 14:52 ` Richard Leitner
2014-08-11 16:15 ` Felipe Balbi
2014-08-20 15:54 ` Felipe Balbi
2014-08-20 16:39 ` Sergei Shtylyov [this message]
2014-08-21 6:57 ` [PATCH] " Richard Leitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F4CF2E.2070605@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=richard.leitner@skidata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).