From: Tadeusz Struk <tadeusz.struk@intel.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linux-firmware@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: Automatically pull missing FW files
Date: Wed, 20 Aug 2014 12:21:23 -0700 [thread overview]
Message-ID: <53F4F533.5010308@intel.com> (raw)
In-Reply-To: <1408559681.11365.1.camel@shinybook.infradead.org>
Hi David,
On 08/20/2014 11:34 AM, David Woodhouse wrote:
> I'm not sure I understand. Precisely what fails?
I clone a subsystem, configure it to use
CONFIG_EXTRA_FIRMWARE="qat_895xcc.bin", type make && make install and get:
MK_FW firmware/qat_895xxc.bin.gen.S
make[1]: *** No rule to make target `firmware/qat_895xxc.bin', needed by
`firmware/qat_895xxc.bin.gen.o'. Stop.
I thought it might be useful if it would pull whatever FW it needs and
not just give up. It also might be useful if one wants to "refresh" the
FW binaries. In this case one can do rm firmware/*.[bin|ihex] && make &&
make install
>
> I don't like this patch very much. We should be removing the legacy
> firmware/ directory entirely, not patching it up.
>
> Userspace is responsible for providing the firmware, and it should
> generally come from an entirely separate checkout of the linux-firmware
> repository.
Yes, if you use udev helper. When you want to compile in the blobs to
your kernel it is needed in build time, right?
In both cases you need the binary anyway so you can copy it manually
from linux-firmware or use this nice feature to do it for you.
If you want to remove firmware/ directory entirely then this makefile
will be gone as well so what's the problem?
next prev parent reply other threads:[~2014-08-20 19:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 18:21 [PATCH] firmware: Automatically pull missing FW files Tadeusz Struk
2014-08-20 18:34 ` David Woodhouse
2014-08-20 19:21 ` Tadeusz Struk [this message]
2014-08-20 20:17 ` Valdis.Kletnieks
2014-08-20 20:39 ` David Woodhouse
2014-08-20 20:48 ` Tadeusz Struk
2014-08-21 12:31 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F4F533.5010308@intel.com \
--to=tadeusz.struk@intel.com \
--cc=dwmw2@infradead.org \
--cc=linux-firmware@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox