From: Georgi Djakov <gdjakov@mm-sol.com>
To: Andy Gross <agross@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@sonymobile.com>
Cc: "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"galak@codeaurora.org" <galak@codeaurora.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
"sboyd@codeaurora.org" <sboyd@codeaurora.org>,
"iivanov@mm-sol.com" <iivanov@mm-sol.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH v1 1/3] pinctrl: qcom: Add APQ8084 pinctrl support
Date: Wed, 20 Aug 2014 23:30:15 +0300 [thread overview]
Message-ID: <53F50557.5070109@mm-sol.com> (raw)
In-Reply-To: <20140820154200.GA14731@qualcomm.com>
On 20.08.14 18:42, Andy Gross wrote:
> On Tue, Aug 19, 2014 at 09:39:30PM -0700, Bjorn Andersson wrote:
>> On Tue 19 Aug 10:22 PDT 2014, Georgi Djakov wrote:
>>
>>> This patch adds support for the TLMM (Top-Level Mode Mux) block found
>>> in the APQ8084 platform.
>>>
>> [...]
>>> +
>>> +#define NUM_GPIO_PINGROUPS 143
>>> +
>>
>> I think this looks good overall, but in my APQ8084 documentation
>> (80-NG550-2X Rev. B) there are 147 (0..146) gpio pins in the TLMM block.
>>
>> Any suggestion to why there's a discrepancy?
>>
>
> We have some discrepancies internally on the documentation. However, in this
> case I'd expect the OEM documentation to be correct. So this needs to change to
> bjorn's version, as it appears to be the correct version.
>
> I have no idea why some pins are missing.
>
Thank you for reviewing, Bjorn and Andy. I'll update and submit v2.
BR,
Georgi
next prev parent reply other threads:[~2014-08-20 20:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 17:22 [PATCH v1 0/3] pinctrl: qcom: Add APQ8084 pinctrl support Georgi Djakov
2014-08-19 17:22 ` [PATCH v1 1/3] " Georgi Djakov
2014-08-20 4:39 ` Bjorn Andersson
2014-08-20 15:42 ` Andy Gross
2014-08-20 20:30 ` Georgi Djakov [this message]
2014-08-20 20:31 ` Andy Gross
2014-08-19 17:22 ` [PATCH v1 2/3] dt: Document Qualcomm APQ8084 pinctrl binding Georgi Djakov
2014-08-19 17:22 ` [PATCH v1 3/3] ARM: dts: Add TLMM DT node for apq8084 Georgi Djakov
2014-08-20 4:41 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F50557.5070109@mm-sol.com \
--to=gdjakov@mm-sol.com \
--cc=agross@codeaurora.org \
--cc=bjorn.andersson@sonymobile.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=iivanov@mm-sol.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox