From: Tadeusz Struk <tadeusz.struk@intel.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linux-firmware@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: Automatically pull missing FW files
Date: Wed, 20 Aug 2014 13:48:47 -0700 [thread overview]
Message-ID: <53F509AF.9010707@intel.com> (raw)
In-Reply-To: <1408567140.9484.0.camel@infradead.org>
On 08/20/2014 01:39 PM, David Woodhouse wrote:
> On Wed, 2014-08-20 at 12:21 -0700, Tadeusz Struk wrote:
>> Hi David,
>> On 08/20/2014 11:34 AM, David Woodhouse wrote:
>>> I'm not sure I understand. Precisely what fails?
>>
>> I clone a subsystem, configure it to use
>> CONFIG_EXTRA_FIRMWARE="qat_895xcc.bin", type make && make install and get:
>>
>> MK_FW firmware/qat_895xxc.bin.gen.S
>> make[1]: *** No rule to make target `firmware/qat_895xxc.bin', needed by
>> `firmware/qat_895xxc.bin.gen.o'. Stop.
>
> Can't you already just use CONFIG_EXTRA_FIRMWARE_DIR ?
What for? The point is that you don't have the FW binary file and you
have to download it, which can happen automatically and this is what
this patch does. The director where it will be stored doesn't really
matter here.
>
>> Yes, if you use udev helper. When you want to compile in the blobs to
>> your kernel it is needed in build time, right?
>
> Yes. But seriously: don't do that. Let firmware get loaded from
> userspace the normal way. Don't build kernel images that you can't distribute
> because they include non-GPL parts.
>
next prev parent reply other threads:[~2014-08-20 20:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 18:21 [PATCH] firmware: Automatically pull missing FW files Tadeusz Struk
2014-08-20 18:34 ` David Woodhouse
2014-08-20 19:21 ` Tadeusz Struk
2014-08-20 20:17 ` Valdis.Kletnieks
2014-08-20 20:39 ` David Woodhouse
2014-08-20 20:48 ` Tadeusz Struk [this message]
2014-08-21 12:31 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F509AF.9010707@intel.com \
--to=tadeusz.struk@intel.com \
--cc=dwmw2@infradead.org \
--cc=linux-firmware@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox