From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752351AbaHUCxN (ORCPT ); Wed, 20 Aug 2014 22:53:13 -0400 Received: from mail-pd0-f176.google.com ([209.85.192.176]:56410 "EHLO mail-pd0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750774AbaHUCxL (ORCPT ); Wed, 20 Aug 2014 22:53:11 -0400 Message-ID: <53F55EB8.3010101@linaro.org> Date: Thu, 21 Aug 2014 10:51:36 +0800 From: Hanjun Guo User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Catalin Marinas CC: "Rafael J. Wysocki" , Mark Rutland , "graeme.gregory@linaro.org" , Arnd Bergmann , Olof Johansson , "grant.likely@linaro.org" , Sudeep Holla , Will Deacon , Jason Cooper , Marc Zyngier , Bjorn Helgaas , Daniel Lezcano , Mark Brown , Rob Herring , Robert Richter , Lv Zheng , Robert Moore , Lorenzo Pieralisi , Liviu Dudau , Randy Dunlap , Charles Garcia-Tobin , "linux-acpi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linaro-acpi@lists.linaro.org" , Tomasz Nowicki Subject: Re: [PATCH v2 06/18] ARM64 / ACPI: Parse MADT to map logical cpu to MPIDR and get cpu_possible/present_map References: <1407166105-17675-1-git-send-email-hanjun.guo@linaro.org> <1407166105-17675-7-git-send-email-hanjun.guo@linaro.org> <20140818142728.GS20043@localhost> <53F2FE8E.60307@linaro.org> <20140820143817.GN24600@localhost> In-Reply-To: <20140820143817.GN24600@localhost> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2014-8-20 22:38, Catalin Marinas wrote: > On Tue, Aug 19, 2014 at 08:36:46AM +0100, Hanjun Guo wrote: >> On 2014-8-18 22:27, Catalin Marinas wrote: >>> On Mon, Aug 04, 2014 at 04:28:13PM +0100, Hanjun Guo wrote: >>>> diff --git a/arch/arm64/include/asm/acpi.h b/arch/arm64/include/asm/acpi.h >>>> index 6e04868..e877967 100644 >>>> --- a/arch/arm64/include/asm/acpi.h >>>> +++ b/arch/arm64/include/asm/acpi.h >>>> @@ -64,6 +64,8 @@ static inline void arch_fix_phys_package_id(int num, u32 slot) { } >>>> extern int (*acpi_suspend_lowlevel)(void); >>>> #define acpi_wakeup_address 0 >>>> >>>> +#define MAX_GIC_CPU_INTERFACE 65535 >>> >>> Does this need to be more than NR_CPUS? >> >> Sometimes yes, CPU structure entries in MADT just like CPU nodes in >> device tree, the number of them may more than NR_CPUS. > > I have a more general question here. In ACPI, is MADT the only way to > build a CPU topology? Unfortunately yes as far as I can tell. > It looks weird that we use GIC properties to > create the cpu_logical_map(). Actually information in GICC structures in MADT will both used for GIC init and SMP init, GICC structures represents CPUs in the system. > A side-effect is that the GIC-related > functions are now scattered all over the kernel rather than being > contained in the GIC driver itself. As patch 12/18 shows, all the GIC related code all contained in the GIC driver, GICC structure is more than GIC-related but also CPUs in the system (I have to admit that the name of GICC in ACPI is confusing). Thanks Hanjun