From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754366AbaHUKdL (ORCPT ); Thu, 21 Aug 2014 06:33:11 -0400 Received: from cantor2.suse.de ([195.135.220.15]:35972 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753820AbaHUKcw (ORCPT ); Thu, 21 Aug 2014 06:32:52 -0400 Message-ID: <53F5CACF.4050600@suse.de> Date: Thu, 21 Aug 2014 12:32:47 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Organization: SUSE LINUX Products GmbH User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Chanwoo Choi , "edubezval@gmail.com" CC: Zhang Rui , "Valentin, Eduardo" , Amit Kachhap , Kukjin Kim , Bartlomiej Zolnierkiewicz , Tomasz Figa , l.majewski@samsung.com, naveen krishna , Kyungmin Park , "linux-pm@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org" , LKML Subject: Re: [PATCHv3] thermal: exynos: Add support for TRIM_RELOAD feature at Exynos3250 References: <1408450078-6296-1-git-send-email-cw00.choi@samsung.com> <1408492364-8012-1-git-send-email-cw00.choi@samsung.com> <53F54D86.9070601@samsung.com> In-Reply-To: <53F54D86.9070601@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Am 21.08.2014 03:38, schrieb Chanwoo Choi: > On 08/20/2014 10:38 PM, edubezval@gmail.com wrote: >> On Tue, Aug 19, 2014 at 7:52 PM, Chanwoo Choi wrote: >>> diff --git a/drivers/thermal/samsung/exynos_tmu_data.c b/drivers/thermal/samsung/exynos_tmu_data.c >>> index aa8e0de..8cd609c 100644 >>> --- a/drivers/thermal/samsung/exynos_tmu_data.c >>> +++ b/drivers/thermal/samsung/exynos_tmu_data.c >>> @@ -95,6 +95,8 @@ static const struct exynos_tmu_registers exynos3250_tmu_registers = { >>> .triminfo_data = EXYNOS_TMU_REG_TRIMINFO, >>> .triminfo_25_shift = EXYNOS_TRIMINFO_25_SHIFT, >>> .triminfo_85_shift = EXYNOS_TRIMINFO_85_SHIFT, >>> + .triminfo_ctrl[0] = EXYNOS_TMU_TRIMINFO_CON1, >>> + .triminfo_ctrl[1] = EXYNOS_TMU_TRIMINFO_CON2, >>> .tmu_ctrl = EXYNOS_TMU_REG_CONTROL, >>> .test_mux_addr_shift = EXYNOS4412_MUX_ADDR_SHIFT, >>> .buf_vref_sel_shift = EXYNOS_TMU_REF_VOLTAGE_SHIFT, >>> @@ -160,8 +162,11 @@ static const struct exynos_tmu_registers exynos3250_tmu_registers = { >>> .temp_level = 95, \ >>> }, \ >>> .freq_tab_count = 2, \ >>> + .triminfo_reload[0] = 0x1, \ >>> + .triminfo_reload[1] = 0x11, \ >> >> What does 0x1 mean? How about 0x11? > > The bit of 'RELOAD' field in TRIMINFO_CONTROL register is [0]. > and The bit of 'AC Time' field in TRIMINFO_CONTROL register is [5:4]. > > 0x1 means that set RELOAD field. > 0x11 means that set RELOAD field and ACTIME field. Might be a good idea to use #defines for 0x1 and 0x10 then? Regards, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg