From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Hayes Wang <hayeswang@realtek.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: nic_swsd <nic_swsd@realtek.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH net-next 3/4] r8152: remove clear_bp function
Date: Thu, 21 Aug 2014 21:29:28 +0400 [thread overview]
Message-ID: <53F62C78.8040404@cogentembedded.com> (raw)
In-Reply-To: <0835B3720019904CB8F7AA43166CEEB2515BB5@RTITMBSV03.realtek.com.tw>
On 08/21/2014 06:12 AM, Hayes Wang wrote:
> [...]
>>> r8152b_disable_aldps(tp);
>>>
>>> - rtl_clear_bp(tp);
>>>
>> Why leave 2 empty lines? One is enough.
> The next patch would use another fucntion at the
> same location. I skip removing the empty line and
> re-adding it again. Is that better to do so? I would
> resend the patches if the answer is yes.
Sorry, I haven't looked at your next patch, too big for me. :-)
> Best Regards,
> Hayes
WBR, Sergei
next prev parent reply other threads:[~2014-08-21 17:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 8:58 [PATCH net-next 0/4] r8152: firmware support Hayes Wang
2014-08-20 8:58 ` [PATCH net-next 1/4] r8152: check code with checkpatch.pl Hayes Wang
2014-08-20 8:58 ` [PATCH net-next 2/4] r8152: replace strncpy with strlcpy Hayes Wang
2014-08-20 8:58 ` [PATCH net-next 3/4] r8152: remove clear_bp function Hayes Wang
2014-08-20 12:00 ` Sergei Shtylyov
[not found] ` <201408210131.s7L1VuAJ031162@rtits1.realtek.com>
2014-08-21 2:12 ` Hayes Wang
2014-08-21 17:29 ` Sergei Shtylyov [this message]
2014-08-22 2:38 ` Hayes Wang
2014-08-20 8:58 ` [PATCH net-next 4/4] r8152: support firmware files Hayes Wang
2014-08-20 12:01 ` Daniele Forsi
2014-08-20 12:35 ` Hayes Wang
2014-08-20 13:32 ` Daniele Forsi
2014-08-24 21:20 ` Francois Romieu
2014-08-25 3:23 ` Hayes Wang
2014-08-23 2:41 ` [PATCH net-next 0/4] r8152: firmware support David Miller
2014-08-25 3:43 ` Hayes Wang
2014-08-25 4:26 ` David Miller
2014-08-25 6:43 ` Hayes Wang
2014-08-25 7:00 ` David Miller
2014-08-25 7:53 ` [PATCH net-next] r8152: check code with checkpatch.pl Hayes Wang
2014-08-25 19:58 ` David Miller
2014-08-26 2:08 ` [PATCH net-next] r8152: replace strncpy with strlcpy Hayes Wang
2014-08-27 23:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F62C78.8040404@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox