From: Antti Palosaari <crope@iki.fi>
To: Jeff Mahoney <jeffm@suse.com>,
Mauro Carvalho Chehab <m.chehab@samsung.com>,
Linux Kernel Maling List <linux-kernel@vger.kernel.org>,
LMML <linux-media@vger.kernel.org>
Subject: Re: Autoselecting SPI for MEDIA_SUBDRV_AUTOSELECT?
Date: Fri, 22 Aug 2014 18:17:22 +0300 [thread overview]
Message-ID: <53F75F02.2030300@iki.fi> (raw)
In-Reply-To: <53F75B26.2020101@suse.com>
Moikka!
On 08/22/2014 06:00 PM, Jeff Mahoney wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi Antti -
>
> Commit e4462ffc160 ([media] Kconfig: sub-driver auto-select SPI bus)
> enables CONFIG_SPI globally for a driver that won't even be enabled in
> many cases.
>
> Is there a reason USB_MSI2500 doesn't select SPI instead of
> MEDIA_SUBDRV_AUTOSELECT?
Nothing but I decided to set it similarly as I2C, another more common
bus. IIRC same was for I2C_MUX too.
You could still disable media subdriver autoselect and then disable SPI
and select all the media drivers (excluding MSSi2500) manually.
I have feeling that media auto-select was added to select everything
needed for media.
regards
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2014-08-22 15:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-22 15:00 Autoselecting SPI for MEDIA_SUBDRV_AUTOSELECT? Jeff Mahoney
2014-08-22 15:17 ` Antti Palosaari [this message]
2014-08-22 15:24 ` Jeff Mahoney
2014-08-22 15:25 ` Antti Palosaari
2014-08-22 15:43 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F75F02.2030300@iki.fi \
--to=crope@iki.fi \
--cc=jeffm@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox