public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: Evgeny Boger <boger@contactless.ru>,
	linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add support for always enabled watchdog timers
Date: Sat, 23 Aug 2014 10:33:06 -0700	[thread overview]
Message-ID: <53F8D052.6060705@roeck-us.net> (raw)
In-Reply-To: <1408814702.730436497@f133.i.mail.ru>

On 08/23/2014 10:25 AM, Alexander Shiyan wrote:
> Sat, 23 Aug 2014 10:16:08 -0700 от Guenter Roeck <linux@roeck-us.net>:
>> On 08/16/2014 05:45 PM, Evgeny Boger wrote:
>>> From: Evgeny Boger <boger@contactless.ru>
>>>
>>> Add option to use with watchdog timers which are always enabled
>>> in hardware, i.e. there is no way to enable/disable it via GPIO pin.
>>> The driver will start pinging WDT immediately upon loading
>>> and will continue to do so even after stopping the watchdog.
>>>
>> The headline needs a reference to the affected driver.
>>
>> Also, please copy the dt mailing list and maintainers.
>>
>>> Signed-off-by: Evgeny Boger <boger@contactless.ru>
>>> ---
>>>    .../devicetree/bindings/watchdog/gpio-wdt.txt      | 14 ++++++-
>>>    drivers/watchdog/gpio_wdt.c                        | 45 +++++++++++++++++-----
>>>    2 files changed, 48 insertions(+), 11 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/watchdog/gpio-wdt.txt b/Documentation/devicetree/bindings/watchdog/gpio-wdt.txt
>>> index 37afec1..1f8ca46 100644
>>> --- a/Documentation/devicetree/bindings/watchdog/gpio-wdt.txt
>>> +++ b/Documentation/devicetree/bindings/watchdog/gpio-wdt.txt
>>> @@ -12,8 +12,11 @@ Required Properties:
>>>        the opposite level disables the WDT. Active level is determined
>>>        by the GPIO flags.
>>>    - hw_margin_ms: Maximum time to reset watchdog circuit (milliseconds).
>>> +- always-enabled: Use with wathdog timer which is always enabled
>
> Similar to NOWAYOUT?
>
I think this one is different. NOWAYOUT is a software flag, while
the flag here is supposed to mean that the hardware watchdog
is always enabled and running, and can not be disabled. Or at least
this is my understanding.

Guenter


  reply	other threads:[~2014-08-23 17:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-17  0:45 [PATCH] Add support for always enabled watchdog timers Evgeny Boger
2014-08-23 17:16 ` Guenter Roeck
2014-08-23 17:25   ` Alexander Shiyan
2014-08-23 17:33     ` Guenter Roeck [this message]
2014-09-06 16:49       ` Evgeny Boger
2014-09-06 16:47   ` [PATCH v2] Add support for always enabled watchdog timers to gpio_wdt driver Evgeny Boger
2014-09-07 17:23     ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F8D052.6060705@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=boger@contactless.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=shc_work@mail.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox