linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Ganesh Rapolu <ganesh.rapolu@hotmail.com>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	David Howells <dhowells@redhat.com>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] DOCUMENTATION: Fixed typo in an example in memory-barriers.txt
Date: Sat, 23 Aug 2014 11:01:01 -0700	[thread overview]
Message-ID: <53F8D6DD.90306@infradead.org> (raw)
In-Reply-To: <BLU436-SMTP214DCCF4135E3E81A493210E2D10@phx.gbl>

On 08/22/14 23:05, Ganesh Rapolu wrote:
> In the first example in the memory-barriers.txt file, CPU 2 is assigned to
> run (x = B; y = A;). However, the rest of the example proceeds as if CPU 2 had been
> running (x = A; y = B;) as shown by the descriptions of the possible executions:
> 
> 	STORE A=3,	STORE B=4,	x=LOAD A->3,	y=LOAD B->4
> 	STORE A=3,	STORE B=4,	y=LOAD B->4,	x=LOAD A->3
> 	STORE A=3,	x=LOAD A->3,	STORE B=4,	y=LOAD B->4
> 	STORE A=3,	x=LOAD A->3,	y=LOAD B->2,	STORE B=4
> 	STORE A=3,	y=LOAD B->2,	STORE B=4,	x=LOAD A->3
> 	STORE A=3,	y=LOAD B->2,	x=LOAD A->3,	STORE B=4
> 	STORE B=4,	STORE A=3,	x=LOAD A->3,	y=LOAD B->4
> 	STORE B=4, ...
> 	...
> 
> The change was merely to make the inital evironment consistent with what happens in the
> rest of the example.
> 
> Signed-off-by: Ganesh Rapolu <ganesh.rapolu@hotmail.com>


Comments David, Alexey, Andrew, Paul?

This would revert Alexey's patch 615cc2c9cf9529846fbc342560d6787c2ccaaeea:
"Documentation/memory-barriers.txt: fix important typo re memory barriers"
that was merged on June 6, 2014.

Thanks.


> ---
>  Documentation/memory-barriers.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/memory-barriers.txt b/Documentation/memory-barriers.txt
> index a4de88f..9a46bbe 100644
> --- a/Documentation/memory-barriers.txt
> +++ b/Documentation/memory-barriers.txt
> @@ -115,8 +115,8 @@ For example, consider the following sequence of events:
>  	CPU 1		CPU 2
>  	===============	===============
>  	{ A == 1; B == 2 }
> -	A = 3;		x = B;
> -	B = 4;		y = A;
> +	A = 3;		x = A;
> +	B = 4;		y = B;
>  
>  The set of accesses as seen by the memory system in the middle can be arranged
>  in 24 different combinations:
> 


-- 
~Randy

  reply	other threads:[~2014-08-23 18:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-23  6:05 [PATCH] DOCUMENTATION: Fixed typo in an example in memory-barriers.txt Ganesh Rapolu
2014-08-23 18:01 ` Randy Dunlap [this message]
2014-08-23 20:17   ` Alexey Dobriyan
2014-08-28 20:01   ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F8D6DD.90306@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=ganesh.rapolu@hotmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).