From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934361AbaHZJ06 (ORCPT ); Tue, 26 Aug 2014 05:26:58 -0400 Received: from cantor2.suse.de ([195.135.220.15]:39406 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932407AbaHZJ05 (ORCPT ); Tue, 26 Aug 2014 05:26:57 -0400 Message-ID: <53FC52DF.2000007@suse.de> Date: Tue, 26 Aug 2014 11:26:55 +0200 From: Hannes Reinecke User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Rasmus Villemoes , "James E.J. Bottomley" CC: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: scsi: #define missing include guards References: <1408711053-14129-1-git-send-email-linux@rasmusvillemoes.dk> In-Reply-To: <1408711053-14129-1-git-send-email-linux@rasmusvillemoes.dk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/22/2014 02:37 PM, Rasmus Villemoes wrote: > The four files aha1542.h, aha1740.h, gvp11.h and mvme147.h under > drivers/scsi/ contain two-thirds of an include guard, but do not > elsewhere. > > Signed-off-by: Rasmus Villemoes > --- > drivers/scsi/aha1542.h | 1 + > drivers/scsi/aha1740.h | 1 + > drivers/scsi/gvp11.h | 1 + > drivers/scsi/mvme147.h | 1 + > 4 files changed, 4 insertions(+) > > diff --git a/drivers/scsi/aha1542.h b/drivers/scsi/aha1542.h > index b871d2b..8f4e07a 100644 > --- a/drivers/scsi/aha1542.h > +++ b/drivers/scsi/aha1542.h > @@ -1,4 +1,5 @@ > #ifndef _AHA1542_H > +#define _AHA1542_H > > /* $Id: aha1542.h,v 1.1 1992/07/24 06:27:38 root Exp root $ > * > diff --git a/drivers/scsi/aha1740.h b/drivers/scsi/aha1740.h > index af23fd6..7ea484f 100644 > --- a/drivers/scsi/aha1740.h > +++ b/drivers/scsi/aha1740.h > @@ -1,4 +1,5 @@ > #ifndef _AHA1740_H > +#define _AHA1740_H > > /* $Id$ > * > diff --git a/drivers/scsi/gvp11.h b/drivers/scsi/gvp11.h > index 852913c..5aabe90 100644 > --- a/drivers/scsi/gvp11.h > +++ b/drivers/scsi/gvp11.h > @@ -1,4 +1,5 @@ > #ifndef GVP11_H > +#define GVP11_H > > /* $Id: gvp11.h,v 1.4 1997/01/19 23:07:12 davem Exp $ > * > diff --git a/drivers/scsi/mvme147.h b/drivers/scsi/mvme147.h > index bfd4566..479e9b4 100644 > --- a/drivers/scsi/mvme147.h > +++ b/drivers/scsi/mvme147.h > @@ -1,4 +1,5 @@ > #ifndef MVME147_H > +#define MVME147_H > > /* $Id: mvme147.h,v 1.4 1997/01/19 23:07:10 davem Exp $ > * > Not that it matter much, but: Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)