From: Jens Axboe <axboe@kernel.dk>
To: Sabrina Dubroca <sd@queasysnail.net>, hch@lst.de
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: fix error handling in sg_io
Date: Tue, 26 Aug 2014 08:17:50 -0600 [thread overview]
Message-ID: <53FC970E.9030607@kernel.dk> (raw)
In-Reply-To: <1409062442-32766-1-git-send-email-sd@queasysnail.net>
On 08/26/2014 08:14 AM, Sabrina Dubroca wrote:
> Before commit 2cada584b200 ("block: cleanup error handling in sg_io"),
> we had ret = 0 before entering the last big if block of sg_io.
>
> Since 2cada584b200, ret = -EFAULT, which breaks hdparm:
>
> /dev/sda:
> setting Advanced Power Management level to 0xc8 (200)
> HDIO_DRIVE_CMD failed: Bad address
> APM_level = 128
>
> Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
> Fixes: 2cada584b200 ("block: cleanup error handling in sg_io")
Thanks, good catch. Someone else reported a regression with identical
symptoms to me yesterday, but did not follow up, so I'm glad you both
found and fixed it.
--
Jens Axboe
next prev parent reply other threads:[~2014-08-26 14:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 13:31 linux-next: hdparm -B <value> broken Sabrina Dubroca
2014-08-26 13:51 ` Christoph Hellwig
2014-08-26 14:14 ` [PATCH] block: fix error handling in sg_io Sabrina Dubroca
2014-08-26 14:17 ` Jens Axboe [this message]
2014-08-26 14:18 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FC970E.9030607@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox