From: Stephen Warren <swarren@wwwdotorg.org>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>,
Mikko Perttunen <mperttunen@nvidia.com>,
Peter De Schrijver <pdeschrijver@nvidia.com>,
Tuomas Tynkkynen <ttynkkynen@nvidia.com>
Cc: linux-pm@vger.kernel.org,
"Thierry Reding" <thierry.reding@gmail.com>,
"Terje Bergström" <tbergstrom@nvidia.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Pavel Machek" <pavel@ucw.cz>, "Len Brown" <len.brown@intel.com>,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
"Javier Martinez Canillas" <javier.martinez@collabora.co.uk>
Subject: Re: [PATCH v4 3/3] memory: tegra124-emc: Add EMC driver
Date: Tue, 26 Aug 2014 11:17:45 -0600 [thread overview]
Message-ID: <53FCC139.6020703@wwwdotorg.org> (raw)
In-Reply-To: <1409058728-13347-4-git-send-email-tomeu.vizoso@collabora.com>
On 08/26/2014 07:12 AM, Tomeu Vizoso wrote:
> Sets the EMC clock rate based on the bandwidth requirements registered by
> memory clients through the PM_QOS_MEMORY_BANDWIDTH class.
>
> Note: this is just an example and not a proper driver for a external memory
> controller. Its only purpose is to illustrate how such a driver would set the
> frequency of the external memory clock based on the bandwidth requirements of
> memory clients.
> diff --git a/arch/arm/mach-tegra/tegra.c b/arch/arm/mach-tegra/tegra.c
> @@ -112,6 +117,11 @@ static void __init tegra_dt_init(void)
> parent = soc_device_to_device(soc_dev);
>
> /*
> + * HACK: register a platform device to probe the driver
> + */
> + platform_device_register(&tegra_emc);
I don't think this is a hack, except for the bug: That should only
happen on Tegra124 not on all Tegra SoCs.
Do you intend all 3 patches in this series to be merged? You'd mentioned
you didn't when asked about this for a previous version. I'm not sure if
that's changed?
To merge, I'd need Thierry's ack on patch 2, and Thierry's, Peter's,
Mikko's, and/or Tuomas's on this patch.
next prev parent reply other threads:[~2014-08-26 17:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 13:12 [PATCH v4 0/3] PM QoS: Add support for memory bandwidth constraints Tomeu Vizoso
2014-08-26 13:12 ` [PATCH v4 1/3] PM / QoS: Add PM_QOS_MEMORY_BANDWIDTH class Tomeu Vizoso
2014-08-26 13:12 ` [PATCH v4 2/3] drm/tegra: Request memory bandwidth for the display controller Tomeu Vizoso
2014-08-26 13:12 ` [PATCH v4 3/3] memory: tegra124-emc: Add EMC driver Tomeu Vizoso
2014-08-26 17:17 ` Stephen Warren [this message]
2014-08-27 7:32 ` Tomeu Vizoso
2014-08-27 16:27 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FCC139.6020703@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=javier.martinez@collabora.co.uk \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=pavel@ucw.cz \
--cc=pdeschrijver@nvidia.com \
--cc=rjw@rjwysocki.net \
--cc=tbergstrom@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=tomeu.vizoso@collabora.com \
--cc=ttynkkynen@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox