From: Florian Fainelli <f.fainelli@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jason Cooper <jason@lakedaemon.net>
Subject: Re: [PATCH v2] genirq: bug on inconstent flags and flow handler
Date: Tue, 26 Aug 2014 16:54:02 -0700 [thread overview]
Message-ID: <53FD1E1A.6020404@gmail.com> (raw)
In-Reply-To: <CAGVrzcbMKOGV20OGWY9n7xw3f=6+oyRvza+qRbCHfbVECmTLNQ@mail.gmail.com>
On 07/23/2014 12:14 PM, Florian Fainelli wrote:
> 2014-07-23 11:49 GMT-07:00 Thomas Gleixner <tglx@linutronix.de>:
>> On Wed, 23 Jul 2014, Florian Fainelli wrote:
>>
>>> It is currently possible for a generic irq chip driver to set IRQ_LEVEL
>>> and have its irq flow handler be handle_edge_irq. Setting IRQ_LEVEL in
>>> such a case does not make sense, and will actually prevent e.g: the
>>> software resend logic from kicking, and potential other problems too.
>>>
>>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>>> ---
>>> Changes in v2:
>>> - replaced WARN_ON() with BUG_ON() since we really don't want to continue
>>> as suggested by Jason Cooper
>>
>> I disagree here. It's not a reason take the machine down. Its good
>> enough to WARN. That keeps the machine alive and lets us debug that
>> stuff.
>
> Works for me!
>
>>
>> Lemme find V1 ....
>
> Here it is: https://lkml.org/lkml/2014/7/1/468
Thomas, do you want me to resubmit that change so you get a clean
submission in your inbox? Thanks
--
Florian
next prev parent reply other threads:[~2014-08-26 23:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 18:45 [PATCH v2] genirq: bug on inconstent flags and flow handler Florian Fainelli
2014-07-23 18:49 ` Thomas Gleixner
2014-07-23 19:14 ` Florian Fainelli
2014-08-26 23:54 ` Florian Fainelli [this message]
2014-08-27 7:49 ` Thomas Gleixner
2014-07-23 23:12 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FD1E1A.6020404@gmail.com \
--to=f.fainelli@gmail.com \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox