From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933095AbaH0F6j (ORCPT ); Wed, 27 Aug 2014 01:58:39 -0400 Received: from mail-pd0-f169.google.com ([209.85.192.169]:44102 "EHLO mail-pd0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932489AbaH0F6i (ORCPT ); Wed, 27 Aug 2014 01:58:38 -0400 Message-ID: <53FD7386.3070805@linaro.org> Date: Wed, 27 Aug 2014 14:58:30 +0900 From: AKASHI Takahiro User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Will Deacon CC: "keescook@chromium.org" , Catalin Marinas , "dsaxena@linaro.org" , "arndb@arndb.de" , "linux-arm-kernel@lists.infradead.org" , "linaro-kernel@lists.linaro.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v6 5/6] arm64: add SIGSYS siginfo for compat task References: <1408611405-8943-1-git-send-email-takahiro.akashi@linaro.org> <1408611405-8943-6-git-send-email-takahiro.akashi@linaro.org> <20140826175526.GF23445@arm.com> In-Reply-To: <20140826175526.GF23445@arm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/27/2014 02:55 AM, Will Deacon wrote: > On Thu, Aug 21, 2014 at 09:56:44AM +0100, AKASHI Takahiro wrote: >> SIGSYS is primarily used in secure computing to notify tracer. >> This patch allows signal handler on compat task to get correct information >> with SA_SYSINFO specified when this signal is delivered. >> >> Signed-off-by: AKASHI Takahiro >> --- >> arch/arm64/include/asm/compat.h | 7 +++++++ >> arch/arm64/kernel/signal32.c | 8 ++++++++ >> 2 files changed, 15 insertions(+) >> >> diff --git a/arch/arm64/include/asm/compat.h b/arch/arm64/include/asm/compat.h >> index 253e33b..c877915 100644 >> --- a/arch/arm64/include/asm/compat.h >> +++ b/arch/arm64/include/asm/compat.h >> @@ -205,6 +205,13 @@ typedef struct compat_siginfo { >> compat_long_t _band; /* POLL_IN, POLL_OUT, POLL_MSG */ >> int _fd; >> } _sigpoll;h >> + >> + /* SIGSYS */ >> + struct { >> + compat_uptr_t _call_addr; /* calling user insn */ >> + int _syscall; /* triggering system call number */ >> + unsigned int _arch; /* AUDIT_ARCH_* of syscall */ >> + } _sigsys; >> } _sifields; >> } compat_siginfo_t; >> >> diff --git a/arch/arm64/kernel/signal32.c b/arch/arm64/kernel/signal32.c >> index 1b9ad02..aa550d6 100644 >> --- a/arch/arm64/kernel/signal32.c >> +++ b/arch/arm64/kernel/signal32.c >> @@ -186,6 +186,14 @@ int copy_siginfo_to_user32(compat_siginfo_t __user *to, const siginfo_t *from) >> err |= __put_user(from->si_uid, &to->si_uid); >> err |= __put_user((compat_uptr_t)(unsigned long)from->si_ptr, &to->si_ptr); >> break; >> +#ifdef __ARCH_SIGSYS >> + case __SI_SYS: >> + err |= __put_user((compat_uptr_t)(unsigned long) >> + from->si_call_addr, &to->si_call_addr); >> + err |= __put_user(from->si_syscall, &to->si_syscall); >> + err |= __put_user(from->si_arch, &to->si_arch); >> + break; >> +#endif > > I think you should drop this #ifdef. We care about whether arch/arm/ defines > __ARCH_SIGSYS, not whether arm64 defines it (they both happen to define it > anyway). Thanks. Done -Takahiro AKASHI > Will >