From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, linaro-kernel@lists.linaro.org,
Mark Brown <broonie@linaro.org>
Subject: Re: [PATCH] regmap: Don't attempt block writes when syncing cache on single_rw devices
Date: Wed, 27 Aug 2014 16:30:47 +0300 [thread overview]
Message-ID: <53FDDD87.4030904@linux.intel.com> (raw)
In-Reply-To: <1409141379-18946-1-git-send-email-broonie@kernel.org>
On 08/27/2014 03:09 PM, Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
>
> If the device can't support block writes then don't attempt to use raw
> syncing which will automatically generate block writes for adjacent
> registers, use the existing _single() block syncing implementation.
>
> Reported-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
> drivers/base/regmap/regcache.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
This works too with RT5642. It appeared page select for _regmap_write()
is actually handled implicitly for certain cases. regmap_init() sets
"map->reg_write = _regmap_bus_raw_write" in this case and
_regmap_bus_raw_write() then calls _regmap_raw_write(). I guess that can
be fixed when doing other cleanups or if some setup hits it.
Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
prev parent reply other threads:[~2014-08-27 13:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 12:09 [PATCH] regmap: Don't attempt block writes when syncing cache on single_rw devices Mark Brown
2014-08-27 13:30 ` Jarkko Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FDDD87.4030904@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=broonie@kernel.org \
--cc=broonie@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox