From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934759AbaH0N4h (ORCPT ); Wed, 27 Aug 2014 09:56:37 -0400 Received: from cantor2.suse.de ([195.135.220.15]:36291 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933404AbaH0N4e (ORCPT ); Wed, 27 Aug 2014 09:56:34 -0400 Message-ID: <53FDE390.4080503@suse.de> Date: Wed, 27 Aug 2014 15:56:32 +0200 From: Hannes Reinecke User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Yoshihiro YUNOMAE CC: linux-scsi@vger.kernel.org, "Martin K. Petersen" , yrl.pp-manager.tt@hitachi.com, linux-kernel@vger.kernel.org, "James E.J. Bottomley" , Hidehiro Kawai , Doug Gilbert , Masami Hiramatsu , Christoph Hellwig Subject: Re: [RFC PATCH 01/10] scsi/constants: Cleanup printk message in __scsi_print_sense() References: <20140808115004.6768.97014.stgit@yuno-kbuild.novalocal> <20140808115006.6768.5118.stgit@yuno-kbuild.novalocal> In-Reply-To: <20140808115006.6768.5118.stgit@yuno-kbuild.novalocal> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/08/2014 01:50 PM, Yoshihiro YUNOMAE wrote: > A device name is output like "sda: Sense Key : Medium Error [current]" > in __scsi_print_sense(), but it should be "[sda] Sense Key : Medium Error > [current]" because other printk messages output a device name like "[sda] foo." > > Signed-off-by: Yoshihiro YUNOMAE > Cc: Hannes Reinecke > Cc: Doug Gilbert > Cc: Martin K. Petersen > Cc: Christoph Hellwig > Cc: "James E.J. Bottomley" > Cc: Hidehiro Kawai > Cc: Masami Hiramatsu > --- > drivers/scsi/constants.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/constants.c b/drivers/scsi/constants.c > index c6a7a4a..a0e8159 100644 > --- a/drivers/scsi/constants.c > +++ b/drivers/scsi/constants.c > @@ -1470,7 +1470,7 @@ void __scsi_print_sense(struct scsi_device *sdev, const char *name, > return; > } > > - sdev_printk(KERN_INFO, sdev, "%s: Sense Key : %s %s%s\n", name, > + sdev_printk(KERN_INFO, sdev, "[%s] Sense Key : %s %s%s\n", name, > scsi_sense_key_string(sshdr.sense_key), > scsi_sense_type_string(&sshdr), > scsi_sense_format_string(&sshdr)); > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > A similar fix is already present in my next version of the scsi logging patchset. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)