public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <maarten.lankhorst@canonical.com>
To: Rob Clark <robdclark@gmail.com>, linux-kernel@vger.kernel.org
Cc: Daniel Vetter <daniel@ffwll.ch>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] ww-mutex: clarify help text for DEBUG_WW_MUTEX_SLOWPATH
Date: Wed, 27 Aug 2014 17:27:23 +0200	[thread overview]
Message-ID: <53FDF8DB.6050703@canonical.com> (raw)
In-Reply-To: <1409152766-31320-1-git-send-email-robdclark@gmail.com>

Acked-by: Maarten Lankhorst <maarten.lankhorst@canonical.com>

On 27-08-14 17:19, Rob Clark wrote:
> We really don't want distro's enabling this in their kernels.  Try and
> make that more clear.
> 
> Signed-off-by: Rob Clark <robdclark@gmail.com>
> ---
>  lib/Kconfig.debug | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 07c2832..1b233fc 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -892,6 +892,10 @@ config DEBUG_WW_MUTEX_SLOWPATH
>  	 the full mutex checks enabled with (CONFIG_PROVE_LOCKING) this
>  	 will test all possible w/w mutex interface abuse with the
>  	 exception of simply not acquiring all the required locks.
> +	 Note that this feature can introduce significant overhead, so
> +	 it really should not be enabled in a production or distro kernel,
> +	 even a debug kernel.  If you are a driver writer, enable it.  If
> +	 you are a distro, do not.
>  
>  config DEBUG_LOCK_ALLOC
>  	bool "Lock debugging: detect incorrect freeing of live locks"
> 

      reply	other threads:[~2014-08-27 15:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-27 15:19 [PATCH] ww-mutex: clarify help text for DEBUG_WW_MUTEX_SLOWPATH Rob Clark
2014-08-27 15:27 ` Maarten Lankhorst [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53FDF8DB.6050703@canonical.com \
    --to=maarten.lankhorst@canonical.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robdclark@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox