From: Caesar Wang <caesar.wang@rock-chips.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: heiko@sntech.de, rui.zhang@intel.com, edubezval@gmail.com,
grant.likely@linaro.org, robh+dt@kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org, huangtao@rock-chips.com,
cf@rock-chips.com, dianders@chromium.org, dtor@chromium.org,
zyw@rock-chips.com, addy.ke@rock-chips.com,
zhaoyifeng <zyf@rock-chips.com>
Subject: Re: [PATCH v2 2/2] dt-bindings: document Rockchip thermal
Date: Thu, 28 Aug 2014 04:36:35 +0800 [thread overview]
Message-ID: <53FE4153.3080601@rock-chips.com> (raw)
In-Reply-To: <5911166.ElkaNhDZrP@wuerfel>
Arnd,
在 2014年08月28日 04:17, Arnd Bergmann 写道:
> On Wednesday 27 August 2014 07:41:43 Caesar Wang wrote:
>> +- clock-names : Shall be "tsadc_clk" for the transfer-clock, and "tsadc_pclk" for
>> + the peripheral clock.
>>
> Why not just name them "clk" and "pclk"? The "tsadc" part seems highly redundant.
>
> Alternatively, how about "transfer" and "peripheral"?
It seems nappropriate description.
But,I will fix as the following:
-clock-names : Shall be "tsadc" for the converter-clock, and "apb_pclk" for
the peripheral clock.
Thanks!
>
> Arnd
>
>
>
--
Best regards,
Caesar
prev parent reply other threads:[~2014-08-27 20:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 23:41 [PATCH v2 0/2] Rockchip soc theamal driver Caesar Wang
2014-08-26 23:41 ` [PATCH v2 1/2] thermal: rockchip: add driver for thermal Caesar Wang
2014-08-27 0:11 ` Dmitry Torokhov
2014-08-27 17:18 ` Caesar Wang
2014-08-27 18:02 ` Dmitry Torokhov
2014-08-27 21:14 ` Caesar Wang
2014-08-26 23:41 ` [PATCH v2 2/2] dt-bindings: document Rockchip thermal Caesar Wang
2014-08-27 20:17 ` Arnd Bergmann
2014-08-27 20:36 ` Caesar Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FE4153.3080601@rock-chips.com \
--to=caesar.wang@rock-chips.com \
--cc=addy.ke@rock-chips.com \
--cc=arnd@arndb.de \
--cc=cf@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dtor@chromium.org \
--cc=edubezval@gmail.com \
--cc=grant.likely@linaro.org \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=zyf@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox