From: Tomasz Figa <tomasz.figa@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Doug Anderson <dianders@chromium.org>,
Olof Johansson <olof@lixom.net>,
Yuvaraj Kumar C D <yuvaraj.cd@gmail.com>,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] regulator: max77802: set opmode to normal if off is read from hw
Date: Wed, 27 Aug 2014 23:03:37 +0200 [thread overview]
Message-ID: <53FE47A9.1020701@gmail.com> (raw)
In-Reply-To: <53FE4286.3050305@gmail.com>
On 27.08.2014 22:41, Tomasz Figa wrote:
> On 27.08.2014 22:25, Mark Brown wrote:
>> On Wed, Aug 27, 2014 at 09:58:55PM +0200, Tomasz Figa wrote:
>>> On 27.08.2014 21:44, Mark Brown wrote:
>>
>>>> The point is that if anything was setting the mode to something other
>>>> than normal it was almost certainly a previously running copy of Linux
>>>> and one would expect that if the mode does need to be changed the new
>>>> copy will be doing that anyway. It's rare enough to need to actively
>>>> manage modes in the first place.
>>
>>> From what I know based on my experience with Samsung boards we used, the
>>> opmodes of regulators are preconfigured by board bootloader to certain
>>> values based on power design of the board (i.e. there is no need to keep
>>> a regulator in full power mode, if on given board only a little fraction
>>> of it is needed).
>>
>> Well, presumably the bootloader is going to run again even for a warm
>> reboot?
>
> This is strange, but apparently it's not the case for the hardware which
> this patch is supposed to fix or at least this is how I understood it.
>
OK, I just realized that Javier's problem might be caused by the fact
that the bootloader he use doesn't change the regulators from defaults
at all. In this case this patch is just fine.
Best regards,
Tomasz
next prev parent reply other threads:[~2014-08-27 21:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 11:37 [PATCH 1/1] regulator: max77802: set opmode to normal if off is read from hw Javier Martinez Canillas
2014-08-26 15:44 ` Doug Anderson
2014-08-27 6:47 ` Yuvaraj Kumar
2014-08-27 17:51 ` Mark Brown
2014-08-27 18:32 ` Tomasz Figa
2014-08-27 18:37 ` Mark Brown
2014-08-27 18:39 ` Tomasz Figa
2014-08-27 18:47 ` Mark Brown
2014-08-27 18:52 ` Tomasz Figa
2014-08-27 19:15 ` Mark Brown
2014-08-27 19:21 ` Tomasz Figa
2014-08-27 19:44 ` Mark Brown
2014-08-27 19:58 ` Tomasz Figa
2014-08-27 20:25 ` Mark Brown
2014-08-27 20:41 ` Tomasz Figa
2014-08-27 21:03 ` Tomasz Figa [this message]
2014-08-27 22:44 ` Javier Martinez Canillas
2014-08-28 8:28 ` Mark Brown
2014-08-28 9:59 ` Javier Martinez Canillas
2014-08-28 10:01 ` Mark Brown
2014-08-27 21:03 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FE47A9.1020701@gmail.com \
--to=tomasz.figa@gmail.com \
--cc=broonie@kernel.org \
--cc=dianders@chromium.org \
--cc=javier.martinez@collabora.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=yuvaraj.cd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox