From: Janet Liu <jianhua.ljh@gmail.com>
To: gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: Fwd: Re: [PATCH] staging:lustre:lnet: lib-md.c fix checkpath warnings and errors.
Date: Thu, 28 Aug 2014 10:23:05 +0800 [thread overview]
Message-ID: <53FE9289.3050809@gmail.com> (raw)
In-Reply-To: <53FE91E1.1020006@qq.com>
On 08/28/2014 10:20 AM, Janet Liu wrote:
>
>
>
> -------- Original Message --------
> Subject: Re: [PATCH] staging:lustre:lnet: lib-md.c fix checkpath
> warnings and errors.
> Date: Tue, 26 Aug 2014 18:22:45 -0700
> From: Greg KH <gregkh@linuxfoundation.org>
> To: Janet Liu <janetliu526@qq.com>
> CC: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
>
> On Mon, Aug 25, 2014 at 01:18:54AM +0800, Janet Liu wrote:
>> Sliences the following warning and error:
>>
>> WARNING: line over 80 characters
>> WARNING: space prohibited between function name and open parenthesis
>> '('
>> ERROR: do not use C99 // comments
>> ERROR: trailing statements should be on next line
>
> You changed 4 things, in one patch :(
>
> Also, you sent 4 different patches, which one is correct?
>
> Please only do one thing per patch and please resend with the one that
> you wish to have reviewed.
>
> thanks,
>
> greg k-h
>
>
Hi Greg,
I'm very sorry for having troubled you.
The latest one is correct. It is send by my gmail box.
The first two is sent by this mailbox(janetliu526@qq.com) and is
rejected by linux-kernel@vger.kernel.org.
The third is tested by dan.carpenter@oracle.com, he told me it broke
build. So I fixed and send the fourth.
Those are all codestyle issue.
regards,
janet
next prev parent reply other threads:[~2014-08-28 2:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1408900734-8256-1-git-send-email-janetliu526@qq.com>
2014-08-27 1:22 ` [PATCH] staging:lustre:lnet: lib-md.c fix checkpath warnings and errors Greg KH
[not found] ` <53FE91E1.1020006@qq.com>
2014-08-28 2:23 ` Janet Liu [this message]
2014-08-28 11:49 ` Fwd: " Dan Carpenter
2014-08-28 15:44 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FE9289.3050809@gmail.com \
--to=jianhua.ljh@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox