* [PATCH] pinctrl: qcom: Release pin ranges when gpiochip_irqchip_add fails
@ 2014-08-27 10:57 Pramod Gurav
2014-08-27 21:24 ` Bjorn Andersson
2014-09-02 12:29 ` Linus Walleij
0 siblings, 2 replies; 6+ messages in thread
From: Pramod Gurav @ 2014-08-27 10:57 UTC (permalink / raw)
To: linux-kernel, linux-arm-msm
Cc: Pramod Gurav, Ivan T. Ivanov, Bjorn Andersson, Linus Walleij
This patches adds a call to gpiochip_remove_pin_ranges when
gpiochip_irqchip_add fails to release memory allocated for pin_ranges.
CC: Ivan T. Ivanov <iivanov@mm-sol.com>
CC: Bjorn Andersson <bjorn.andersson@sonymobile.com>
CC: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Pramod Gurav <pramod.gurav@smartplayin.com>
---
drivers/pinctrl/qcom/pinctrl-msm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
index f4e4f8f..aa34b5a 100644
--- a/drivers/pinctrl/qcom/pinctrl-msm.c
+++ b/drivers/pinctrl/qcom/pinctrl-msm.c
@@ -845,6 +845,7 @@ static int msm_gpio_init(struct msm_pinctrl *pctrl)
IRQ_TYPE_NONE);
if (ret) {
dev_err(pctrl->dev, "Failed to add irqchip to gpiochip\n");
+ gpiochip_remove_pin_ranges(chip);
return -ENOSYS;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] pinctrl: qcom: Release pin ranges when gpiochip_irqchip_add fails
2014-08-27 10:57 [PATCH] pinctrl: qcom: Release pin ranges when gpiochip_irqchip_add fails Pramod Gurav
@ 2014-08-27 21:24 ` Bjorn Andersson
2014-08-28 7:13 ` Pramod Gurav
2014-09-02 12:29 ` Linus Walleij
1 sibling, 1 reply; 6+ messages in thread
From: Bjorn Andersson @ 2014-08-27 21:24 UTC (permalink / raw)
To: Pramod Gurav
Cc: linux-kernel@vger.kernel.org, linux-arm-msm, Ivan T. Ivanov,
Bjorn Andersson, Linus Walleij
On Wed, Aug 27, 2014 at 3:57 AM, Pramod Gurav
<pramod.gurav@smartplayin.com> wrote:
> This patches adds a call to gpiochip_remove_pin_ranges when
> gpiochip_irqchip_add fails to release memory allocated for pin_ranges.
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
> @@ -845,6 +845,7 @@ static int msm_gpio_init(struct msm_pinctrl *pctrl)
> IRQ_TYPE_NONE);
> if (ret) {
> dev_err(pctrl->dev, "Failed to add irqchip to gpiochip\n");
> + gpiochip_remove_pin_ranges(chip);
> return -ENOSYS;
> }
Good catch, I guess this was lost in the introduction of gpiochip_irqchip...
Rather than just releasing the pin_ranges of the gpio_chip you should
probably add a gpiochip_remove() both here and in the case of
gpiochip_add_pin_range() failing.
Regards,
Bjorn
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] pinctrl: qcom: Release pin ranges when gpiochip_irqchip_add fails
2014-08-27 21:24 ` Bjorn Andersson
@ 2014-08-28 7:13 ` Pramod Gurav
2014-08-29 3:49 ` Bjorn Andersson
0 siblings, 1 reply; 6+ messages in thread
From: Pramod Gurav @ 2014-08-28 7:13 UTC (permalink / raw)
To: Bjorn Andersson
Cc: linux-kernel@vger.kernel.org, linux-arm-msm, Ivan T. Ivanov,
Bjorn Andersson, Linus Walleij
On Thursday 28 August 2014 02:54 AM, Bjorn Andersson wrote:
> On Wed, Aug 27, 2014 at 3:57 AM, Pramod Gurav
> <pramod.gurav@smartplayin.com> wrote:
>> This patches adds a call to gpiochip_remove_pin_ranges when
>> gpiochip_irqchip_add fails to release memory allocated for pin_ranges.
>>
>> diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
>> @@ -845,6 +845,7 @@ static int msm_gpio_init(struct msm_pinctrl *pctrl)
>> IRQ_TYPE_NONE);
>> if (ret) {
>> dev_err(pctrl->dev, "Failed to add irqchip to gpiochip\n");
>> + gpiochip_remove_pin_ranges(chip);
>> return -ENOSYS;
>> }
>
> Good catch, I guess this was lost in the introduction of gpiochip_irqchip...
>
>
> Rather than just releasing the pin_ranges of the gpio_chip you should
> probably add a gpiochip_remove() both here and in the case of
> gpiochip_add_pin_range() failing.
Thanks for review. But if I see implementation of gpiochip_remove() it does:
gpiochip_irqchip_remove(chip);
gpiochip_remove_pin_ranges(chip);
of_gpiochip_remove(chip);
In above failure case only gpiochip_add() and gpiochip_add_pin_range()
have been successful hence I thought that would cause any problem to add
gpiochip_remove(). If that is not a problem I think we can call
gpiochip_remove() in fail case of gpiochip_add_pin_range() as well.
Do I make sense?
>
> Regards,
> Bjorn
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] pinctrl: qcom: Release pin ranges when gpiochip_irqchip_add fails
2014-08-28 7:13 ` Pramod Gurav
@ 2014-08-29 3:49 ` Bjorn Andersson
2014-08-29 7:19 ` Pramod Gurav
0 siblings, 1 reply; 6+ messages in thread
From: Bjorn Andersson @ 2014-08-29 3:49 UTC (permalink / raw)
To: Pramod Gurav
Cc: Bjorn Andersson, linux-kernel@vger.kernel.org, linux-arm-msm,
Ivan T. Ivanov, Linus Walleij
On Thu 28 Aug 00:13 PDT 2014, Pramod Gurav wrote:
> On Thursday 28 August 2014 02:54 AM, Bjorn Andersson wrote:
> > On Wed, Aug 27, 2014 at 3:57 AM, Pramod Gurav
> > <pramod.gurav@smartplayin.com> wrote:
> >> This patches adds a call to gpiochip_remove_pin_ranges when
> >> gpiochip_irqchip_add fails to release memory allocated for pin_ranges.
> >>
> >> diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
> >> @@ -845,6 +845,7 @@ static int msm_gpio_init(struct msm_pinctrl *pctrl)
> >> IRQ_TYPE_NONE);
> >> if (ret) {
> >> dev_err(pctrl->dev, "Failed to add irqchip to gpiochip\n");
> >> + gpiochip_remove_pin_ranges(chip);
> >> return -ENOSYS;
> >> }
> >
> > Good catch, I guess this was lost in the introduction of gpiochip_irqchip...
> >
> >
> > Rather than just releasing the pin_ranges of the gpio_chip you should
> > probably add a gpiochip_remove() both here and in the case of
> > gpiochip_add_pin_range() failing.
>
> Thanks for review. But if I see implementation of gpiochip_remove() it does:
> gpiochip_irqchip_remove(chip);
> gpiochip_remove_pin_ranges(chip);
> of_gpiochip_remove(chip);
>
> In above failure case only gpiochip_add() and gpiochip_add_pin_range()
> have been successful hence I thought that would cause any problem to add
> gpiochip_remove(). If that is not a problem I think we can call
> gpiochip_remove() in fail case of gpiochip_add_pin_range() as well.
> Do I make sense?
>
As soon as gpiochip_add() have returned successfully we will have a live
gpio_chip, upon returning unsuccessfully from probe devres will free the pctrl
node and the gpio core will continue to operate on freed memory.
Therefor we need to call gpio_remove() in the ccase of both
gpiochip_add_pin_range() and gpiochip_irqchip_add() failing.
The gpio_remove() does as you say remove those additional items, but handles
the case where they are not yet "allocated".
I hope this answers your conserns.
Regards,
Bjorn
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] pinctrl: qcom: Release pin ranges when gpiochip_irqchip_add fails
2014-08-29 3:49 ` Bjorn Andersson
@ 2014-08-29 7:19 ` Pramod Gurav
0 siblings, 0 replies; 6+ messages in thread
From: Pramod Gurav @ 2014-08-29 7:19 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Bjorn Andersson, linux-kernel@vger.kernel.org, linux-arm-msm,
Ivan T. Ivanov, Linus Walleij
On 29-08-2014 09:19 AM, Bjorn Andersson wrote:
> On Thu 28 Aug 00:13 PDT 2014, Pramod Gurav wrote:
>
>> On Thursday 28 August 2014 02:54 AM, Bjorn Andersson wrote:
>>> On Wed, Aug 27, 2014 at 3:57 AM, Pramod Gurav
>>> <pramod.gurav@smartplayin.com> wrote:
>>>> This patches adds a call to gpiochip_remove_pin_ranges when
>>>> gpiochip_irqchip_add fails to release memory allocated for pin_ranges.
>>>>
>>>> diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
>>>> @@ -845,6 +845,7 @@ static int msm_gpio_init(struct msm_pinctrl *pctrl)
>>>> IRQ_TYPE_NONE);
>>>> if (ret) {
>>>> dev_err(pctrl->dev, "Failed to add irqchip to gpiochip\n");
>>>> + gpiochip_remove_pin_ranges(chip);
>>>> return -ENOSYS;
>>>> }
>>>
>>> Good catch, I guess this was lost in the introduction of gpiochip_irqchip...
>>>
>>>
>>> Rather than just releasing the pin_ranges of the gpio_chip you should
>>> probably add a gpiochip_remove() both here and in the case of
>>> gpiochip_add_pin_range() failing.
>>
>> Thanks for review. But if I see implementation of gpiochip_remove() it does:
>> gpiochip_irqchip_remove(chip);
>> gpiochip_remove_pin_ranges(chip);
>> of_gpiochip_remove(chip);
>>
>> In above failure case only gpiochip_add() and gpiochip_add_pin_range()
>> have been successful hence I thought that would cause any problem to add
>> gpiochip_remove(). If that is not a problem I think we can call
>> gpiochip_remove() in fail case of gpiochip_add_pin_range() as well.
>> Do I make sense?
>>
>
> As soon as gpiochip_add() have returned successfully we will have a live
> gpio_chip, upon returning unsuccessfully from probe devres will free the pctrl
> node and the gpio core will continue to operate on freed memory.
>
> Therefor we need to call gpio_remove() in the ccase of both
> gpiochip_add_pin_range() and gpiochip_irqchip_add() failing.
>
> The gpio_remove() does as you say remove those additional items, but handles
> the case where they are not yet "allocated".
>
> I hope this answers your conserns.
That really does. Thanks for your time. Will resend the patch with
handling failure cases of both gpiochip_add_pin_range() and
gpiochip_irqchip_add().
>
> Regards,
> Bjorn
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] pinctrl: qcom: Release pin ranges when gpiochip_irqchip_add fails
2014-08-27 10:57 [PATCH] pinctrl: qcom: Release pin ranges when gpiochip_irqchip_add fails Pramod Gurav
2014-08-27 21:24 ` Bjorn Andersson
@ 2014-09-02 12:29 ` Linus Walleij
1 sibling, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2014-09-02 12:29 UTC (permalink / raw)
To: Pramod Gurav
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Ivan T. Ivanov, Bjorn Andersson
On Wed, Aug 27, 2014 at 12:57 PM, Pramod Gurav
<pramod.gurav@smartplayin.com> wrote:
> This patches adds a call to gpiochip_remove_pin_ranges when
> gpiochip_irqchip_add fails to release memory allocated for pin_ranges.
>
> CC: Ivan T. Ivanov <iivanov@mm-sol.com>
> CC: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> CC: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Pramod Gurav <pramod.gurav@smartplayin.com>
Dropping this one as the gpiochip_remove() patch fixes the
problem.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-09-02 12:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-27 10:57 [PATCH] pinctrl: qcom: Release pin ranges when gpiochip_irqchip_add fails Pramod Gurav
2014-08-27 21:24 ` Bjorn Andersson
2014-08-28 7:13 ` Pramod Gurav
2014-08-29 3:49 ` Bjorn Andersson
2014-08-29 7:19 ` Pramod Gurav
2014-09-02 12:29 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox