Re: [PATCHv3 6/8] x86/mm: Provide ARCH_GET_UNTAG_MASK and ARCH_ENABLE_TAGGED_ADDR

Kirill A. Shutemov
2022-07-04T13:43:48Z

On Sat, Jul 02, 2022 at 04:55:40PM -0700, Andy Lutomirski wrote:
> > diff --git a/arch/x86/kernel/process_64.c b/arch/x86/kernel/process_64.c
> > index 427ebef3f64b..cd2b03fe94c4 100644
> > --- a/arch/x86/kernel/process_64.c
> > +++ b/arch/x86/kernel/process_64.c
> > @@ -745,15 +745,16 @@ static long prctl_map_vdso(const struct
> > vdso_image *image, unsigned long addr)
> > static void enable_lam_func(void *mm)
> > {
> > struct mm_struct *loaded_mm = this_cpu_read(cpu_tlbstate.loaded_mm);
> > + unsigned long lam_mask;
> >
> > if (loaded_mm != mm)
> > return;
> >
> > - /* Counterpart of smp_wmb() in prctl_enable_tagged_addr() */
> > - smp_rmb();
> > + lam_mask = READ_ONCE(loaded_mm->context.lam_cr3_mask);
> >
> > /* Update CR3 to get LAM active on the CPU */
> > - switch_mm(loaded_mm, loaded_mm, current);
> > + write_cr3(__read_cr3() | lam_mask);
>
> Perhaps this should also mask off the old LAM mask?

So far LAM enabling is one-way operation, so it should be fine.
But I think masking off is good idea to avoid problems in the future.

--
Kirill A. Shutemov