From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A40B9342517 for ; Sat, 16 May 2026 19:25:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778959516; cv=none; b=VofwS5kjR/UQKdC4jBCfCnuJToecChD+XfC3kxSV1FhUYSD/DLFib08NQnviJgK6Xmi9klUaXbHoUoZvXq2q0xtdDt17gcAzugMPfVJy7LtKFTxGwJR4YlUXqKACQhWgc9n9RcAQho/Z+49sXRERmeWm5WdrrQT6gfjfVfoo5wc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778959516; c=relaxed/simple; bh=Rch9BlJKm86u2jFjWPy/exsEl++VNJ8K47Z8YCQbhlY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=obiMgPWH/VPVpZn9W7zFPd4N+08e+WkDK1BNgg8IKx7fpRXhg8tRNQCdpzM0sFNHq0SIknpWHoyJWOJhCsBv+fAPo6W/s5/PZ2a5Rb2wwJ6evfOpUcU8ZrKGRqPcEeeAbVSZPxX1zozdXxN7ZmbIyr+CCBdAXSX6pJpI4vX8Dxc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b=sjV3WU6g; arc=none smtp.client-ip=209.85.210.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b="sjV3WU6g" Received: by mail-ot1-f54.google.com with SMTP id 46e09a7af769-7dcdaf06498so647403a34.2 for ; Sat, 16 May 2026 12:25:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1778959511; x=1779564311; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7fPwesdjsiyiHQsIQO0tND7lOMwn0nsVsfr8NNzx7zw=; b=sjV3WU6gDdb0fiziRhotQ9qQeXC8VEmtLrnNWudUrByaxsuCsYa6AxQqE7/fkBNGPa V0AcgN6U7M7K9+/wxUOvV5ss0LytD1wpmk7nYvA3JkRiFwUshu6bCauzBjpM5hgT6r1n FA1MqINegzVeAVmmqnQ5guYze+89oNRBAh/+iTCIeXIe9H/c7g5Hp/U2AFHakAodC87T apYqtK50GdRB7ljIC1f1ZtiaJh69wCnTCFcmOl256m6B56ldux7Sv+Wz5zP73e4yYsKF cE29cBTu2UeceI2qgFk/9DPET6JS8IG+hKpuzY43oIM9ctwxWA5I4/uOJ2LNyu31wYng umxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778959511; x=1779564311; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7fPwesdjsiyiHQsIQO0tND7lOMwn0nsVsfr8NNzx7zw=; b=DGJli/iVDVtDQQq5kYJJ9TfoEQkoakEDy1Md6/6gr5LqNJR3BHEMsTMljvIStoGXjB 5rUr1Ej65pjSLS1JB+qpmYI/8UVf0AQFdJ5Wnt7ZeCfvK6FOSLx69matKC4/lGCKhWfS N/w7TH8WeoQ8VRO72jiAJp/oBBiSFgKQO9cu6Hw7d6s+OUx5jrGB4z4wgwzEUVjP3mMu M5638WySck/ICUhtKSXGWI8JTjk26XAGGpSeONUQD12wKccnB1oPB2R92CyIEKPVSpfr gL1ACQ+Xu8M9D95eaBrdyZ7oZEJ4YNOpaqBlWPUknfwDEJqY0gWiZn/kLPeBNSdtw/Jg WNaw== X-Forwarded-Encrypted: i=1; AFNElJ/PuRKPYQBhMwTVQupmhiC0ZOi2jdWsWXEK2PjjWDfyU5XK/yTI1ZdQ42lqWMej5IEVqCoLT0C8zvU89h0=@vger.kernel.org X-Gm-Message-State: AOJu0YwlnunWnckERRBFLw8rG9XOJt/WnmEmYcaK3cOgitF57bZv4zWs vhOaFo13qzOXJeaLeulZn/FIRuxR1xd/tahT1i58Yk10hWowKFrSLvMIqW8hma1lLZ8= X-Gm-Gg: Acq92OGuiqn9U0NYZGwLGf6TOAfZ642nbmxm71MxA0A/bPgaEs8LfbQKE1GNBFonXX9 JjVoAsWgjR5q0O8/1t/VJuFOwi930FaVifFubFkOhC8Li+dJ6a2f+Vk8/ZNc6udBIf0tmF0G9PU 5gt3I22QqL9nPqu5tKSIlil6YnxO4R/ArE0iBBzKZA1GtafjXrzd7D/JR6qUZMfa1WCiTHQ0XqJ l6HW+GhHUcDSG0bCCSjUHdhWoyNGHf1y4VEE9FXbF62K8E83njSEL4aLdWQIrl7vGF3Up2Lwild T21Qo0196WgzInLHRvD0zztqq43TIcSXhtfEKwnQCRQCydGX9L840qfKdBzJ7VShfw/MM9huDzk SkPKBWK86ZamvwfbzOvAqbhZq9+3CnllfDhD6hLSOwxMTqrEYH4xTewejJDxJY3xbzZ1h2V95kl jJFQR+79kw+4wuedKrxmgjQP7HkWRkMy4VHnsB3dYVjJ/d2xoKdCDE0Rg8VJsWaH6vObkZdk8hW g== X-Received: by 2002:a05:6830:4704:b0:7d7:4ee9:c39a with SMTP id 46e09a7af769-7e4ea031993mr6198970a34.4.1778959511638; Sat, 16 May 2026 12:25:11 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:b36d:bd18:7c02:29e2? ([2600:8803:e7e4:500:b36d:bd18:7c02:29e2]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7e55b507cbesm4126569a34.0.2026.05.16.12.25.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 16 May 2026 12:25:10 -0700 (PDT) Message-ID: <53d547ee-1ac3-42b9-92a6-e7f48b72fee3@baylibre.com> Date: Sat, 16 May 2026 14:25:09 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] dt-bindings: iio: dac: Add AD5529R To: Jonathan Cameron , Janani Sunil Cc: Lars-Peter Clausen , Michael Hennerich , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Jonathan Corbet , Shuah Khan , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Janani Sunil , rodrigo.alencar@analog.com References: <20260508-ad5529r-driver-v2-0-e315441685d7@analog.com> <20260508-ad5529r-driver-v2-1-e315441685d7@analog.com> <20260508134843.7646c4f5@jic23-huawei> Content-Language: en-US From: David Lechner In-Reply-To: <20260508134843.7646c4f5@jic23-huawei> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/8/26 7:48 AM, Jonathan Cameron wrote: > On Fri, 8 May 2026 13:55:47 +0200 > Janani Sunil wrote: > >> Devicetree bindings for AD5529R 16 channel 12/16 bit high voltage, >> buffered voltage output digital-to-analog converter (DAC) with an >> integrated precision reference. >> >> Signed-off-by: Janani Sunil >> --- ... >> + * Multiplexer for output voltage, load current sense and die temperature >> + >> + Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/ad5529r.pdf >> + >> +properties: >> + compatible: >> + const: adi,ad5529r >> + >> + reg: >> + maxItems: 1 >> + >> + spi-max-frequency: >> + maximum: 50000000 >> + >> + reset-gpios: >> + maxItems: 1 >> + description: >> + GPIO connected to the RESET pin. Active low. When asserted low, >> + performs a power-on reset and initializes the device to its default state. >> + >> + vdd-supply: >> + description: Digital power supply (typically 3.3V) >> + >> + avdd-supply: >> + description: Analog power supply (typically 5V) >> + >> + hvdd-supply: >> + description: High voltage positive supply (up to 40V for output range) >> + >> + hvss-supply: >> + description: High voltage negative supply (ground or negative voltage) > > I don't mind doing it this way but in some similar cases where 0 is something that > can be considered the 'default' we've made the supply optional. What was > your reasoning for requiring it in this case? > > dt-bindings should be as complete as we can make them - with that in mind... > > There are some more interesting corners on this device the binding doesn't > currently cover such as mux_out pin. We'd normally do that by making the > driver potentially a client of an ADC > > Easier though is !alarm which smells like an interrupt. > !clear probably a gpio. TG0-3 also GPIOs. also optional vref-supply for external vs internal reference > >> + >> +required: >> + - compatible >> + - reg >> + - vdd-supply >> + - avdd-supply >> + - hvdd-supply >> + - hvss-supply >