From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C614C13A248 for ; Tue, 27 Feb 2024 11:17:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709032663; cv=none; b=SMIdi1Zy2fHRu94nuOUkNgOZbjSKHJoAXeKsvm5hk/PcKw2+vkzXtl06sLophjgpY1g8W11+azSTZK5Ge1bwlcaq3zJrFHGyyIpKOvIb8a/PohPxqaCGMPDnP4Bj6HG27uh88xJrQi/P3GeiGLhToipfDxeYj0H9z52tFWkVwSM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709032663; c=relaxed/simple; bh=zMx9VNg0jW7yErLfdX4OtpOb+mzigK+UY/JrcAVpYN0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=d0ZfgfQv3WEm+wlv54nfJnMJdp8LKK5QxIBzIv5buQM4Nc5AoGIywo9I3HIj6+u6s6oX28hlIM8ekJDandTkNmSoYzF0VVSqc0bgFq+sLOGTLwHydZ14WDl433f2Vmzt+oVYNnujPTDCm05jYuSELLfNqRgs/8lWvxgFgLhyEjo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 888D2DA7; Tue, 27 Feb 2024 03:18:19 -0800 (PST) Received: from [10.1.197.1] (ewhatever.cambridge.arm.com [10.1.197.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 744AB3F6C4; Tue, 27 Feb 2024 03:17:40 -0800 (PST) Message-ID: <53f6cac5-cdfd-42e3-88e4-9725575adff4@arm.com> Date: Tue, 27 Feb 2024 11:17:33 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Correcting the spelling mistakes in "Documentation/ABI/testing/sysfs-bus-cxl" and "Documentation/ABI/testing/sysfs-bus-coresight-devices-tmc" Content-Language: en-US To: prabhav kumar Cc: mike.leach@linaro.org, james.clark@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20240220214212.10231-1-pvkumar5749404@gmail.com> <02138784-d9fd-4331-bb34-fe1bd2fd043f@arm.com> From: Suzuki K Poulose In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 26/02/2024 18:58, prabhav kumar wrote: > Thanks for commenting on the patch. > > Will generate another patch for corresponding subsystem. > I had ran the get_maintainer script on the CXL subsystem , but didn't > get any maintainer's name other than the commit_signers Another nit: Please do not top post your replies. Use inline replies. https://en.wikipedia.org/wiki/Posting_style#Interleaved_style Suzuki > > Thanks, > Prabhav > > On Mon, Feb 26, 2024 at 9:25 PM Suzuki K Poulose > wrote: > > Hi Prabhav, > > > On 20/02/2024 21:42, Prabhav Kumar Vaish wrote: > > Thanks for sending the patch. Please find some comments. > > > Signed-off-by: Prabhav Kumar Vaish > > > Only one "Signed-off-by:" tag is required, the second one below > is at the desired location. So, please drop the above. > > > > > > Changes: > >       - "avaialble" corrected to "available" in > "Documentation/ABI/testing/sysfs-bus-coresight-devices-tmc" > >       - "firwmare" corrected to "firmware" in > "Documentation/ABI/testing/sysfs-bus-cxl" > > It is advisable to split this patch into two, as they affect files > maintained by different subsystems. i.e., coresight and CXL. Since > they go via different maintainers, it is always better to split > the patch (especially when there is no functional dependency, like > this case). > > Also, I see that you haven't copied any of the maintainers for the CXL > subsystem. Running "scripts/get_maintainer.pl > " on the affected file > or the patch should give you the email addresses for the concerned > maintainers/list. > > e.g: > > $ scripts/get_maintainer.pl > Documentation/ABI/testing/sysfs-bus-cxl > > So, please resend the patch after splitting, to the respective > maintainers/reviewers/list. > > Suzuki > > > Signed-off-by: Prabhav Kumar Vaish > > > --- > >   Documentation/ABI/testing/sysfs-bus-coresight-devices-tmc | 2 +- > >   Documentation/ABI/testing/sysfs-bus-cxl                   | 2 +- > >   2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git > a/Documentation/ABI/testing/sysfs-bus-coresight-devices-tmc > b/Documentation/ABI/testing/sysfs-bus-coresight-devices-tmc > > index 96aafa66b4a5..339cec3b2f1a 100644 > > --- a/Documentation/ABI/testing/sysfs-bus-coresight-devices-tmc > > +++ b/Documentation/ABI/testing/sysfs-bus-coresight-devices-tmc > > @@ -97,7 +97,7 @@ Date:               August 2023 > >   KernelVersion:      6.7 > >   Contact:    Anshuman Khandual > > >   Description:        (Read) Shows all supported Coresight > TMC-ETR buffer modes available > > -             for the users to configure explicitly. This file is > avaialble only > > +             for the users to configure explicitly. This file is > available only > >               for TMC ETR devices. > > > >   What: >  /sys/bus/coresight/devices/.tmc/buf_mode_preferred > > diff --git a/Documentation/ABI/testing/sysfs-bus-cxl > b/Documentation/ABI/testing/sysfs-bus-cxl > > index fff2581b8033..bbf6de5a4ca1 100644 > > --- a/Documentation/ABI/testing/sysfs-bus-cxl > > +++ b/Documentation/ABI/testing/sysfs-bus-cxl > > @@ -224,7 +224,7 @@ Description: > >               decoding a Host Physical Address range. Note that > this number > >               may be elevated without any regionX objects active > or even > >               enumerated, as this may be due to decoders > established by > > -             platform firwmare or a previous kernel (kexec). > > +             platform firmware or a previous kernel (kexec). > > > > > >   What:               /sys/bus/cxl/devices/decoderX.Y >