From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Mike Turquette <mturquette@linaro.org>,
linux-kernel@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>,
Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
linux-arm-kernel@lists.infradead.org,
Lior Amsalem <alior@marvell.com>,
Tawfik Bayouk <tawfik@marvell.com>,
Nadav Haklai <nadavh@marvell.com>,
Raphael Rigo <ml-arm@syscall.eu>,
Arnaud Ebalard <arno@natisbad.org>,
Simon Boulay <simon.boulay@vitec.com>
Subject: Re: [PATCH 2/4] clk: mvebu: armada-370: Fix timer drift caused by the SSCG deviation
Date: Fri, 29 Aug 2014 15:37:06 +0200 [thread overview]
Message-ID: <54008202.4090008@free-electrons.com> (raw)
In-Reply-To: <20140829150821.66f1d03d@free-electrons.com>
Hi Thomas,
On 29/08/2014 15:08, Thomas Petazzoni wrote:
> Dear Gregory CLEMENT,
>
> On Fri, 29 Aug 2014 13:43:38 +0200, Gregory CLEMENT wrote:
>
>> +bool a370_is_sscg_enabled(void __iomem *sar)
>
> Minor nit: "static" is missing here.
OK I will fix it in the next version
Thanks,
Gregory
>
>> +{
>> + return !(readl(sar) & SARL_A370_SSCG_ENABLE);
>> +}
>> +
>> static const struct coreclk_soc_desc a370_coreclks = {
>> .get_tclk_freq = a370_get_tclk_freq,
>> .get_cpu_freq = a370_get_cpu_freq,
>> .get_clk_ratio = a370_get_clk_ratio,
>> + .is_sscg_enabled = a370_is_sscg_enabled,
>> .ratios = a370_coreclk_ratios,
>> .num_ratios = ARRAY_SIZE(a370_coreclk_ratios),
>> };
>
> Thomas
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2014-08-29 13:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 11:43 [PATCH 0/4] clk:mvebu: Improve clock drift Gregory CLEMENT
2014-08-29 11:43 ` [PATCH 1/4] clk: mvebu: Fix clk frequency value if SSCG is enabled Gregory CLEMENT
2014-08-29 12:48 ` Sebastian Hesselbarth
2014-08-29 13:35 ` Gregory CLEMENT
2014-08-31 22:25 ` Leigh Brown
2014-08-31 22:30 ` Leigh Brown
2014-09-01 7:17 ` Gregory CLEMENT
2014-08-29 11:43 ` [PATCH 2/4] clk: mvebu: armada-370: Fix timer drift caused by the SSCG deviation Gregory CLEMENT
2014-08-29 13:08 ` Thomas Petazzoni
2014-08-29 13:37 ` Gregory CLEMENT [this message]
2014-08-29 11:43 ` [PATCH 3/4] ARM: mvebu: add SSCG to Armada 370 Device Tree Gregory CLEMENT
2014-08-29 11:43 ` [PATCH 4/4] clk: mvebu: armada-375: Fix the description of the SAR in the comment Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54008202.4090008@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=arno@natisbad.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ml-arm@syscall.eu \
--cc=mturquette@linaro.org \
--cc=nadavh@marvell.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=simon.boulay@vitec.com \
--cc=tawfik@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox