From: "Lu, Baolu" <baolu.lu@linux.intel.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
Sarah Sharp <sarah.a.sharp@linux.intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Mathias Nyman <mathias.nyman@intel.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] USB: Add device quirk for ASUS T100 Base Station keyboard
Date: Sat, 30 Aug 2014 11:16:00 +0800 [thread overview]
Message-ID: <540141F0.7080207@linux.intel.com> (raw)
In-Reply-To: <54006B0A.2050902@cogentembedded.com>
On 8/29/2014 7:59 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 8/29/2014 8:26 AM, Lu Baolu wrote:
>
>> This full-speed USB device generates spurious remote wakeup event
>> as soon as USB_DEVICE_REMOTE_WAKEUP feature is set. As the result,
>> Linux can't enter system suspend and S0ix power saving modes once
>> this keyboard is used.
>
>> This patch tries to introduce USB_QUIRK_IGNOR_REMOTE_WAKEUP quirk.
>
> Why not IGNORE? This doesn't look like a big save...
Sure, will change it.
>
>> With this quirk set, wakeup capability will be ignored during
>> device configure.
>
>> This patch could be back-ported to kernels as old as 2.6.39.
>
>> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
>
> WBR, Sergei
>
prev parent reply other threads:[~2014-08-30 3:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 4:26 [PATCH 1/1] USB: Add device quirk for ASUS T100 Base Station keyboard Lu Baolu
2014-08-29 11:59 ` Sergei Shtylyov
2014-08-30 3:16 ` Lu, Baolu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540141F0.7080207@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=sarah.a.sharp@linux.intel.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox