From: Jonathan Cameron <jic23@kernel.org>
To: Nicolas Ferre <nicolas.ferre@atmel.com>,
Josh Wu <josh.wu@atmel.com>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
maxime.ripard@free-electrons.com
Cc: alexandre.belloni@free-electrons.com
Subject: Re: [PATCH] iio: adc: at91: make the function handle_adc_eoc_trigger() static
Date: Sat, 30 Aug 2014 10:48:02 +0100 [thread overview]
Message-ID: <54019DD2.30509@kernel.org> (raw)
In-Reply-To: <53FD987B.50601@atmel.com>
On 27/08/14 09:36, Nicolas Ferre wrote:
> On 27/08/2014 10:31, Josh Wu :
>> The handle_adc_eoc_trigger() in only used in at91_adc.c. So make it
>> static.
>>
>> Signed-off-by: Josh Wu <josh.wu@atmel.com>
>
> Absolutely.
>
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>
Applied to the togreg branch of iio.git
Thanks,
Jonathan
> Thanks, bye.
>
>> ---
>> drivers/iio/adc/at91_adc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c
>> index 772e869..7807e0e 100644
>> --- a/drivers/iio/adc/at91_adc.c
>> +++ b/drivers/iio/adc/at91_adc.c
>> @@ -266,7 +266,7 @@ static irqreturn_t at91_adc_trigger_handler(int irq, void *p)
>> }
>>
>> /* Handler for classic adc channel eoc trigger */
>> -void handle_adc_eoc_trigger(int irq, struct iio_dev *idev)
>> +static void handle_adc_eoc_trigger(int irq, struct iio_dev *idev)
>> {
>> struct at91_adc_state *st = iio_priv(idev);
>>
>>
>
>
prev parent reply other threads:[~2014-08-30 9:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 8:31 [PATCH] iio: adc: at91: make the function handle_adc_eoc_trigger() static Josh Wu
2014-08-27 8:36 ` Nicolas Ferre
2014-08-30 9:48 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54019DD2.30509@kernel.org \
--to=jic23@kernel.org \
--cc=alexandre.belloni@free-electrons.com \
--cc=josh.wu@atmel.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=nicolas.ferre@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox