[PATCH] staging: comedi: usbdux: fix sparse endianness warnings

[PATCH] staging: comedi: usbdux: fix sparse endianness warnings

[Chase Southwood]

Sparse has many warnings like:

drivers/staging/comedi/drivers/usbdux.c:366:32: warning: cast to
restricted __le16

on lines on which devpriv->in_buf or devpriv->insn_buf are passed to
le16_to_cpu().  This suggests that both of these variables should actually
be of type __le16.

Signed-off-by: Chase Southwood <chase.southwood@gmail.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
---
This is, as usual, compile tested only.  I tried to verify as best as I
could that this is a sane change, but I am unable to test on the hardware.

 drivers/staging/comedi/drivers/usbdux.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/usbdux.c b/drivers/staging/comedi/drivers/usbdux.c
index 053bc50..e1a19222 100644
--- a/drivers/staging/comedi/drivers/usbdux.c
+++ b/drivers/staging/comedi/drivers/usbdux.c
@@ -198,9 +198,9 @@ struct usbdux_private {
 	/* size of the PWM buffer which holds the bit pattern */
 	int pwm_buf_sz;
 	/* input buffer for the ISO-transfer */
-	uint16_t *in_buf;
+	__le16 *in_buf;
 	/* input buffer for single insn */
-	uint16_t *insn_buf;
+	__le16 *insn_buf;
 
 	unsigned int ao_readback[USBDUX_NUM_AO_CHAN];
 
-- 
2.1.0

Re: [PATCH] staging: comedi: usbdux: fix sparse endianness warnings

[Ian Abbott]

On 30/08/14 02:40, Chase Southwood wrote:
> Sparse has many warnings like:
>
> drivers/staging/comedi/drivers/usbdux.c:366:32: warning: cast to
> restricted __le16
>
> on lines on which devpriv->in_buf or devpriv->insn_buf are passed to
> le16_to_cpu().  This suggests that both of these variables should actually
> be of type __le16.
>
> Signed-off-by: Chase Southwood <chase.southwood@gmail.com>
> Cc: Ian Abbott <abbotti@mev.co.uk>
> Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
> ---
> This is, as usual, compile tested only.  I tried to verify as best as I
> could that this is a sane change, but I am unable to test on the hardware.
>
>   drivers/staging/comedi/drivers/usbdux.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/usbdux.c b/drivers/staging/comedi/drivers/usbdux.c
> index 053bc50..e1a19222 100644
> --- a/drivers/staging/comedi/drivers/usbdux.c
> +++ b/drivers/staging/comedi/drivers/usbdux.c
> @@ -198,9 +198,9 @@ struct usbdux_private {
>   	/* size of the PWM buffer which holds the bit pattern */
>   	int pwm_buf_sz;
>   	/* input buffer for the ISO-transfer */
> -	uint16_t *in_buf;
> +	__le16 *in_buf;
>   	/* input buffer for single insn */
> -	uint16_t *insn_buf;
> +	__le16 *insn_buf;
>
>   	unsigned int ao_readback[USBDUX_NUM_AO_CHAN];
>
>

That seems fine.  Perhaps the variable 'p' in usbdux_ao_insn_write() 
should also be of type '__le16 *'?

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-

Re: [PATCH] staging: comedi: usbdux: fix sparse endianness warnings

[Chase Southwood]

On Sat, Aug 30, 2014 at 5:40 AM, Ian Abbott <abbotti@mev.co.uk> wrote:
>
> That seems fine.  Perhaps the variable 'p' in usbdux_ao_insn_write() should
> also be of type '__le16 *'?
>

You're entirely correct.  I had seen this in the output from Sparse,
but for some reason at first glance I had convinced myself that the
fix would be more complicated than it is.  I'll get a patch out with a
Suggested-by: tag for you very soon.

Thanks,
Chase

> Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
>
> --
> -=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk>        )=-
> -=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-