From: Michal Simek <monstr@monstr.eu>
To: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arch/microblaze/include/asm/entry.h: Include "linux/linkage.h" to avoid compiling issue
Date: Mon, 01 Sep 2014 15:59:36 +0200 [thread overview]
Message-ID: <54047BC8.4010308@monstr.eu> (raw)
In-Reply-To: <53E22E85.9010205@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1649 bytes --]
On 08/06/2014 03:32 PM, Chen Gang wrote:
> "entry.h" needs 'asmlinkage', and "asm/linkage.h" does not provide it.
> So need include "linux/linkage.h" to use generic one instead of.
>
> The related error (with allmodconfig under microblaze):
>
> CC [M] drivers/net/ethernet/emulex/benet/be_main.o
> In file included from ./arch/microblaze/include/asm/processor.h:17:0,
> from include/linux/prefetch.h:14,
> from drivers/net/ethernet/emulex/benet/be_main.c:18:
> ./arch/microblaze/include/asm/entry.h:33:19: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'void'
> extern asmlinkage void do_notify_resume(struct pt_regs *regs, int in_syscall);
> ^
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
> arch/microblaze/include/asm/entry.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/microblaze/include/asm/entry.h b/arch/microblaze/include/asm/entry.h
> index b4a4cb1..596e485 100644
> --- a/arch/microblaze/include/asm/entry.h
> +++ b/arch/microblaze/include/asm/entry.h
> @@ -15,6 +15,7 @@
>
> #include <asm/percpu.h>
> #include <asm/ptrace.h>
> +#include <linux/linkage.h>
>
> /*
> * These are per-cpu variables required in entry.S, among other
>
Applied.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2014-09-01 13:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 13:32 [PATCH] arch/microblaze/include/asm/entry.h: Include "linux/linkage.h" to avoid compiling issue Chen Gang
2014-08-19 15:47 ` Chen Gang
2014-08-24 8:06 ` Chen Gang
2014-09-01 13:40 ` Michal Simek
2014-09-01 15:30 ` Chen Gang
2014-09-01 14:01 ` Michal Simek
2014-09-01 13:59 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54047BC8.4010308@monstr.eu \
--to=monstr@monstr.eu \
--cc=gang.chen.5i5j@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox