From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752498AbaIBBol (ORCPT ); Mon, 1 Sep 2014 21:44:41 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:46028 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751711AbaIBBoj (ORCPT ); Mon, 1 Sep 2014 21:44:39 -0400 Message-ID: <540520FC.1090709@gmail.com> Date: Tue, 02 Sep 2014 09:44:28 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: "H. Peter Anvin" , Paul Gortmaker CC: eparis@redhat.com, paulmck@linux.vnet.ibm.com, Geert Uytterhoeven , zhenglong.cai@cs2c.com.cn, khilman@linaro.org, ak@linux.intel.com, mcgrof@suse.com, fabf@skynet.be, "dhowells@redhat.com" , pefoley2@pefoley.com, mgorman@suse.de, biederm@xmission.com, "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" , Arnd Bergmann , Jean Delvare Subject: Re: [PATCH] init/Kconfig: Add ENDIAN attributes for all architectures using References: <540494D6.40701@gmail.com> <20140901160828.GJ26632@windriver.com> <5404A66E.509@zytor.com> In-Reply-To: <5404A66E.509@zytor.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/02/2014 01:01 AM, H. Peter Anvin wrote: > On 09/01/2014 09:08 AM, Paul Gortmaker wrote: >>>> >>> diff --git a/init/Kconfig b/init/Kconfig >>> index ac033c3..f301cc8 100644 >>> --- a/init/Kconfig >>> +++ b/init/Kconfig >>> @@ -23,6 +23,12 @@ config CONSTRUCTORS >>> config IRQ_WORK >>> bool >>> >>> +config CPU_LITTLE_ENDIAN >>> + bool >>> + >>> +config CPU_BIG_ENDIAN >>> + bool >> >> Perhaps you should take a cursory look at what already exists in tree >> before blindly trying to add more to it? >> >> $ git grep CPU_BIG_ENDIAN | wc -l >> 88 >> > > The whole point of this patchset is to make these already widely-used > options universal across the tree. > Yeah, maybe the patch comments need be improved (mention about what you said above) to avoid other members' misunderstanding. If it is necessary (complete the comments), please let me know (I shall send patch v2 for it). Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed