From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752966AbaIBHnj (ORCPT ); Tue, 2 Sep 2014 03:43:39 -0400 Received: from mail-wg0-f47.google.com ([74.125.82.47]:55352 "EHLO mail-wg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752272AbaIBHnh (ORCPT ); Tue, 2 Sep 2014 03:43:37 -0400 Message-ID: <54057526.9050503@gmail.com> Date: Tue, 02 Sep 2014 09:43:34 +0200 From: Daniel Mack User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Klaus Goger , Dmitry Torokhov CC: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Input: cap1106 - fix register definition References: <1409639544-30420-1-git-send-email-klaus.goger@theobroma-systems.com> In-Reply-To: <1409639544-30420-1-git-send-email-klaus.goger@theobroma-systems.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/02/2014 08:32 AM, Klaus Goger wrote: > Use the correct register address for Calibration Active and Interrupt > Enable > > Signed-off-by: Klaus Goger These register definitions are currently unused, but your fix is correct. Just curious - are you planning to send patches that make use of them? Acked-by: Daniel Mack Thanks, Daniel > --- > drivers/input/keyboard/cap1106.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/keyboard/cap1106.c b/drivers/input/keyboard/cap1106.c > index 180b184..d70b65a 100644 > --- a/drivers/input/keyboard/cap1106.c > +++ b/drivers/input/keyboard/cap1106.c > @@ -33,8 +33,8 @@ > #define CAP1106_REG_SENSOR_CONFIG 0x22 > #define CAP1106_REG_SENSOR_CONFIG2 0x23 > #define CAP1106_REG_SAMPLING_CONFIG 0x24 > -#define CAP1106_REG_CALIBRATION 0x25 > -#define CAP1106_REG_INT_ENABLE 0x26 > +#define CAP1106_REG_CALIBRATION 0x26 > +#define CAP1106_REG_INT_ENABLE 0x27 > #define CAP1106_REG_REPEAT_RATE 0x28 > #define CAP1106_REG_MT_CONFIG 0x2a > #define CAP1106_REG_MT_PATTERN_CONFIG 0x2b >