From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754960AbaIBRjh (ORCPT ); Tue, 2 Sep 2014 13:39:37 -0400 Received: from service87.mimecast.com ([91.220.42.44]:57365 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754925AbaIBRjf convert rfc822-to-8bit (ORCPT ); Tue, 2 Sep 2014 13:39:35 -0400 Message-ID: <54060105.5070707@arm.com> Date: Tue, 02 Sep 2014 18:40:21 +0100 From: Sudeep Holla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Greg Kroah-Hartman CC: Sudeep Holla , LKML , Heiko Carstens , Lorenzo Pieralisi , Stephen Boyd , David Herrmann , Kay Sievers Subject: Re: [PATCH] drivers: base: add cpu_device_create to support per-cpu devices References: <1408706963-23195-1-git-send-email-sudeep.holla@arm.com> <5405FCBF.2050100@arm.com> <20140902172632.GA8238@kroah.com> In-Reply-To: <20140902172632.GA8238@kroah.com> X-OriginalArrivalTime: 02 Sep 2014 17:39:32.0220 (UTC) FILETIME=[DABCB3C0:01CFC6D4] X-MC-Unique: 114090218393300901 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Greg, On 02/09/14 18:26, Greg Kroah-Hartman wrote: > On Tue, Sep 02, 2014 at 06:22:07PM +0100, Sudeep Holla wrote: >> Hi Greg, >> >> On 22/08/14 12:29, Sudeep Holla wrote: >>> From: Sudeep Holla >>> >>> This patch adds a new function to create per-cpu devices. >>> This helps in: >>> 1. reusing the device infrastructure to create any cpu related >>> attributes and corresponding sysfs instead of creating and >>> dealing with raw kobjects directly >>> 2. retaining the legacy path(/sys/devices/system/cpu/..) to support >>> existing sysfs ABI >>> 3. avoiding to create links in the bus directory pointing to the >>> device as there would be per-cpu instance of these devices with >>> the same name since dev->bus is not populated to cpu_sysbus on >>> purpose >>> >>> Signed-off-by: Sudeep Holla >>> Cc: Greg Kroah-Hartman >>> --- >>> drivers/base/cpu.c | 54 +++++++++++++++++++++++++++++++++++++++++++++++++++++ >>> include/linux/cpu.h | 4 ++++ >>> 2 files changed, 58 insertions(+) >>> >>> Hi Greg, >>> >>> Here is the alternate solution I could come up with instead of >>> creating cpu class. cpu_device_create is very similar to >>> device_create_groups_vargs w/o class support, but I could not >>> reuse anything else to avoid creating similar function. >>> >>> Let me know your thoughts/suggestions on this. >>> >> >> Any feedback on this ? If ok, I will respin cacheinfo series removing >> cpu class creation with this patch. > > Please address the issues others have already raised. > If you meant issues raised on cacheinfo series, I have addressed them already in v3(raised by you, Stephen Boyd, Mark and Russell). I have retained hotplug notifiers which Stephen wanted to remove as I don't know if that's acceptable on all the architectures. I posted this single patch as a replacement to the patch creating cpu class as Kay and David suggested that we can't have class and bus with same name. Regards, Sudeep